Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't quota events.k8s.io events by default #110939

Merged
merged 1 commit into from Aug 4, 2022
Merged

don't quota events.k8s.io events by default #110939

merged 1 commit into from Aug 4, 2022

Conversation

Abirdcfly
Copy link
Member

@Abirdcfly Abirdcfly commented Jul 4, 2022 •
edited

Signed-off-by: Abirdcfly fp544037857@gmail.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

see #110888
updated from #89179

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 4, 2022
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 4, 2022
@Abirdcfly Abirdcfly mentioned this pull request Jul 4, 2022
Merged
@Abirdcfly
Copy link
Member Author

/retest

@Abirdcfly
Copy link
Member Author

/cc @deads2k

for approve

@k8s-ci-robot k8s-ci-robot requested a review from deads2k July 6, 2022 01:21
@leilajal
Copy link
Contributor

leilajal commented Jul 7, 2022

/assign @deads2k
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 7, 2022
@Abirdcfly
Copy link
Member Author

/cc @lavalamp

Please take a look here, similar to #110888

@Abirdcfly
don't quota events.k8s.io events by default
9680e3f 
Signed-off-by: Abirdcfly <fp544037857@gmail.com>
@lavalamp
Copy link
Member

lavalamp commented Aug 3, 2022

/lgtm
/approve

I think this should probably go into the release but since code is frozen, you probably need someone from the release team to agree with me

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 3, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Abirdcfly, lavalamp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2022
@Abirdcfly
Copy link
Member Author

/cc @kubernetes/milestone-maintainers

Request /milestone v1.25 tag from release team.

@cici37
Copy link
Contributor

cici37 commented Aug 4, 2022

Since it is a bug fix and been approved and LGTMed, tag milestone label to let it in.
/milestone v1.25

@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Aug 4, 2022
@k8s-ci-robot k8s-ci-robot merged commit b661944 into kubernetes:master Aug 4, 2022
@openshift-ci-robot openshift-ci-robot mentioned this pull request Aug 15, 2022
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Oct 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavalamp lavalamp lavalamp left review comments

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@lavalamp lavalamp

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Abirdcfly @leilajal @lavalamp @k8s-ci-robot @cici37 @deads2k