Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote minReadySeconds to GA #110896

Conversation

ravisantoshgudimetla
Copy link
Contributor

@ravisantoshgudimetla ravisantoshgudimetla commented Jul 1, 2022

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Promote StatefulSet minReadySeconds to GA. This means `--feature-gates=StatefulSetMinReadySeconds=true` are not needed on kube-apiserver and kube-controller-manager binaries and they'll be removed soon following policy at https://kubernetes.io/docs/reference/using-api/deprecation-policy/#deprecation 

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: <link> https://github.com/kubernetes/enhancements/pull/3354 
- [Usage]: Promote StatefulSet minReadySeconds to GA. This means `--feature-gates=StatefulSetMinReadySeconds=true` are not needed on kube-apiserver and kube-controller-manager binaries and they'll be removed soon following policy at https://kubernetes.io/docs/reference/using-api/deprecation-policy/#deprecation
- [Usage]: https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/#minimum-ready-seconds

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/code-generation area/test labels Jul 1, 2022
@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 1, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Jul 1, 2022

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@ravisantoshgudimetla ravisantoshgudimetla force-pushed the promote-minReadySec-sts-update-ga branch from c2477cd to 854e996 Compare Jul 1, 2022
@ravisantoshgudimetla
Copy link
Contributor Author

ravisantoshgudimetla commented Jul 1, 2022

/test pull-kubernetes-e2e-gce-alpha-features

@leilajal
Copy link
Contributor

leilajal commented Jul 7, 2022

/assign @alexzielenski @yliaog
thanks for looking into this!
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 7, 2022
@yliaog
Copy link
Contributor

yliaog commented Jul 7, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2022
Copy link
Contributor

@alexzielenski alexzielenski left a comment

/lgtm

@ravisantoshgudimetla
Copy link
Contributor Author

ravisantoshgudimetla commented Jul 11, 2022

/assign @liggitt

for API reviews

@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2022
@atiratree
Copy link
Member

atiratree commented Jul 13, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2022
@atiratree
Copy link
Member

atiratree commented Jul 13, 2022

/test pull-kubernetes-unit

@liggitt
Copy link
Member

liggitt commented Jul 13, 2022

unit test flake looks related to #110923 (comment)

@liggitt
Copy link
Member

liggitt commented Jul 13, 2022

alpha failure does not look related to this gate

/retest

@@ -995,7 +996,7 @@ var defaultKubernetesFeatureGates = map[featuregate.Feature]featuregate.FeatureS

StatefulSetAutoDeletePVC: {Default: false, PreRelease: featuregate.Alpha},

StatefulSetMinReadySeconds: {Default: true, PreRelease: featuregate.Beta},
StatefulSetMinReadySeconds: {Default: true, PreRelease: featuregate.GA, LockToDefault: true},
Copy link
Member

@liggitt liggitt Jul 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment to remove in 1.27

@liggitt
Copy link
Member

liggitt commented Jul 13, 2022

one nit on the feature gate removal comment, and would like an approve from sig-apps-approvers

@ravisantoshgudimetla ravisantoshgudimetla force-pushed the promote-minReadySec-sts-update-ga branch from 634b536 to 63d3bba Compare Jul 13, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2022
@ravisantoshgudimetla ravisantoshgudimetla force-pushed the promote-minReadySec-sts-update-ga branch from 63d3bba to 9ab807f Compare Jul 13, 2022
@liggitt
Copy link
Member

liggitt commented Jul 13, 2022

/approve
for API changes

needs an approve from an apps approver

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2022
@ravisantoshgudimetla
Copy link
Contributor Author

ravisantoshgudimetla commented Jul 13, 2022

/retest

Copy link
Contributor

@soltysh soltysh left a comment

/lgtm
/approve
from sig-apps pov

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2022
@soltysh
Copy link
Contributor

soltysh commented Jul 14, 2022

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 14, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexzielenski, liggitt, ravisantoshgudimetla, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ravisantoshgudimetla
Copy link
Contributor Author

ravisantoshgudimetla commented Jul 14, 2022

/test pull-kubernetes-e2e-gce-ubuntu-containerd

@k8s-ci-robot k8s-ci-robot merged commit e5f4f8d into kubernetes:master Jul 14, 2022
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
API Reviews
API review completed, 1.25
Development

Successfully merging this pull request may close these issues.

None yet

10 participants