-
Notifications
You must be signed in to change notification settings - Fork 39.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote minReadySeconds to GA #110896
Promote minReadySeconds to GA #110896
Conversation
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
c2477cd
to
854e996
Compare
/test pull-kubernetes-e2e-gce-alpha-features |
/assign @alexzielenski @yliaog |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @liggitt for API reviews |
/lgtm |
/test pull-kubernetes-unit |
unit test flake looks related to #110923 (comment) |
alpha failure does not look related to this gate /retest |
pkg/features/kube_features.go
Outdated
@@ -995,7 +996,7 @@ var defaultKubernetesFeatureGates = map[featuregate.Feature]featuregate.FeatureS | |||
|
|||
StatefulSetAutoDeletePVC: {Default: false, PreRelease: featuregate.Alpha}, | |||
|
|||
StatefulSetMinReadySeconds: {Default: true, PreRelease: featuregate.Beta}, | |||
StatefulSetMinReadySeconds: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment to remove in 1.27
one nit on the feature gate removal comment, and would like an approve from sig-apps-approvers |
634b536
to
63d3bba
Compare
63d3bba
to
9ab807f
Compare
/approve needs an approve from an apps approver |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
from sig-apps pov
/priority important-longterm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexzielenski, liggitt, ravisantoshgudimetla, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-kubernetes-e2e-gce-ubuntu-containerd |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: