Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #110075: Add retry logic for Unix Domain sockets on Windows #110935

Merged
merged 1 commit into from Aug 11, 2022
Merged

Automated cherry pick of #110075: Add retry logic for Unix Domain sockets on Windows #110935

merged 1 commit into from Aug 11, 2022

Conversation

luckerby
Copy link
Contributor

@luckerby luckerby commented Jul 3, 2022

Cherry pick of #110075 on release-1.24.

#110075: Add retry logic for Unix Domain sockets on Windows

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jul 3, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 3, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @luckerby. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jul 3, 2022
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 3, 2022
@andyzhangx
Copy link
Member

/kind bug
/priority important-soon
/sig windows
/triage accepted
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/windows Categorizes an issue or PR as relevant to SIG Windows. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 7, 2022
@andyzhangx
Copy link
Member

/retest

@marosset marosset added this to Open backport PRs in SIG-Windows Jul 13, 2022
@jsturtevant
Copy link
Contributor

/retest

@jsturtevant
Copy link
Contributor

/lgtm
/assign @mrunalp @marosset

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 21, 2022
@marosset
Copy link
Contributor

/lgtm

@endocrimes endocrimes added this to Triage in SIG Node PR Triage Jul 26, 2022
@endocrimes endocrimes moved this from Triage to Needs Reviewer in SIG Node PR Triage Jul 26, 2022
@pacoxu pacoxu moved this from Needs Reviewer to Needs Approver in SIG Node PR Triage Aug 3, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: luckerby, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2022
@mrunalp mrunalp moved this from Needs Approver to Done in SIG Node PR Triage Aug 10, 2022
@bridgetkromhout
Copy link
Member

/cc kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested a review from a team August 10, 2022 17:48
@Verolop
Copy link

Verolop commented Aug 10, 2022

/lgtm

@Verolop Verolop added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 11, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Aug 11, 2022
@k8s-ci-robot k8s-ci-robot merged commit 0b08f3c into kubernetes:release-1.24 Aug 11, 2022
SIG-Windows automation moved this from Open backport PRs to Done (v1.25) Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@tallclair tallclair Awaiting requested review from tallclair

Assignees

@mrunalp mrunalp

@jsturtevant jsturtevant

@Verolop Verolop

@marosset marosset

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
SIG-Windows
  
Done (v1.25)
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@luckerby @k8s-ci-robot @andyzhangx @jsturtevant @marosset @bridgetkromhout @Verolop @mrunalp