Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kubelet panic when accessing metrics/resource endpoint #111141

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Fix kubelet panic when accessing metrics/resource endpoint #111141

merged 1 commit into from
Jul 14, 2022
+117 −6

Conversation

yangjunmyfm192085
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fix kubelet panic when accessing metrics/resource endpoint

Which issue(s) this PR fixes:

Fixes #111136

Special notes for your reviewer:

Does this PR introduce a user-facing change?

 "NONE"

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 14, 2022
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 14, 2022
wzshiming
wzshiming approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@wzshiming wzshiming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 14, 2022
@249043822
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 14, 2022
@249043822
Copy link
Member

/assign @dashpole @mrunalp

yangjunmyfm192085
yangjunmyfm192085 commented Jul 14, 2022
View reviewed changes
Copy link
Contributor Author

@yangjunmyfm192085 yangjunmyfm192085 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest

yangjunmyfm192085
yangjunmyfm192085 commented Jul 14, 2022
View reviewed changes
Copy link
Contributor Author

@yangjunmyfm192085 yangjunmyfm192085 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest

@dashpole
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, wzshiming, yangjunmyfm192085

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2022
yangjunmyfm192085
yangjunmyfm192085 commented Jul 14, 2022
View reviewed changes
Copy link
Contributor Author

@yangjunmyfm192085 yangjunmyfm192085 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest

@yangjunmyfm192085
Copy link
Contributor Author

/retest

@ialidzhikov
Copy link
Contributor

@yangjunmyfm192085 can you backport to all effected versions? Thanks in advance!

@k8s-ci-robot k8s-ci-robot merged commit f2395bb into kubernetes:master Jul 14, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jul 14, 2022
This was referenced Jul 15, 2022
Merged
Merged
Merged
@249043822
Copy link
Member

Have cherry-picked to 1.24 1.23 1.22

k8s-ci-robot added a commit that referenced this pull request Aug 10, 2022
@k8s-ci-robot
Merge pull request #111164 from 249043822/automated-cherry-pick-of-#1…
904cb5d 
…11141-upstream-release-1.23

Automated cherry pick of #111141: Fix kubelet panic when accessing metrics/resource endpoint
k8s-ci-robot added a commit that referenced this pull request Aug 10, 2022
@k8s-ci-robot
Merge pull request #111163 from 249043822/automated-cherry-pick-of-#1…
cd41123 
…11141-upstream-release-1.24

Automated cherry pick of #111141: Fix kubelet panic when accessing metrics/resource endpoint
k8s-ci-robot added a commit that referenced this pull request Aug 10, 2022
@k8s-ci-robot
Merge pull request #111165 from 249043822/automated-cherry-pick-of-#1…
2fb9d05 
…11141-upstream-release-1.22

Automated cherry pick of #111141: Fix kubelet panic when accessing metrics/resource endpoint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wzshiming wzshiming wzshiming approved these changes

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@mrunalp mrunalp

@dashpole dashpole

@wzshiming wzshiming

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Archived in project
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

kubelet panic when accessing metrics/resource endpoint
7 participants
@yangjunmyfm192085 @249043822 @dashpole @k8s-ci-robot @ialidzhikov @wzshiming @mrunalp