Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-596: Move CSIInlineVolume feature to GA #111258

Merged
merged 2 commits into from Aug 5, 2022

Conversation

dobsonj
Copy link
Member

@dobsonj dobsonj commented Jul 19, 2022

What type of PR is this?

/kind feature
/sig storage
/milestone v1.25
/triage accepted
/priority important-soon

What this PR does / why we need it:

This updates the feature gates to move CSIInlineVolume from beta to GA in 1.25.

Which issue(s) this PR fixes:

Enhancement: KEP-596.

Special notes for your reviewer:

/cc @gnufied @jsafrane @xing-yang @jingxu97

I'd like to start review and e2e tests, but
/hold for remaining graduation criteria before merging.

The API changes are only for removal of the feature gate and references to it in the generated docs.
/kind api-change
/label api-review

Does this PR introduce a user-facing change?

The CSIInlineVolume feature has moved from beta to GA.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot requested review from gnufied and jingxu97 Jul 19, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2022
@k8s-ci-robot k8s-ci-robot requested a review from jsafrane Jul 19, 2022
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 19, 2022
@k8s-ci-robot k8s-ci-robot requested a review from xing-yang Jul 19, 2022
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 19, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 19, 2022

@dobsonj: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

What type of PR is this?

/kind feature
/sig storage
/milestone v1.25
/triage accepted
/priority important-soon

What this PR does / why we need it:

This updates the feature gates to move CSIInlineVolume from beta to GA in 1.25.

Which issue(s) this PR fixes:

Enhancement: KEP-596.

Special notes for your reviewer:

/cc @gnufied @jsafrane @xing-yang @jingxu97

I'd like to start review and e2e tests, but
/hold for remaining graduation criteria before merging.

The API changes are only for removal of the feature gate and references to it in the generated docs.
/kind api-change
/label api-review

Does this PR introduce a user-facing change?

The CSIInlineVolume feature has moved from beta to GA.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. sig/storage Categorizes an issue or PR as relevant to SIG Storage. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. api-review Categorizes an issue or PR as actively needing an API review. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. area/code-generation sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. labels Jul 19, 2022
@dobsonj dobsonj changed the title KEP-596: Move CSIInlineVolume feature to GA [WIP] KEP-596: Move CSIInlineVolume feature to GA Jul 19, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 19, 2022
@dobsonj dobsonj force-pushed the kep-596-ga-feature-flag branch from c0ca811 to 3ccd39a Compare Jul 19, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 19, 2022
@dobsonj dobsonj force-pushed the kep-596-ga-feature-flag branch 2 times, most recently from 44b3d30 to 963e6b9 Compare Jul 20, 2022
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 20, 2022
@dobsonj dobsonj changed the title [WIP] KEP-596: Move CSIInlineVolume feature to GA KEP-596: Move CSIInlineVolume feature to GA Jul 20, 2022
@cici37
Copy link
Contributor

cici37 commented Aug 3, 2022

Hello 👋, 1.25 Release Lead here.

Unfortunately, this enhancement did not meet the code freeze criteria because there are still unmerged k/k code PRs.

If you still wish to progress this enhancement in v1.25, please file an exception request. Thank you so much!

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.25 milestone Aug 3, 2022
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. area/test sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/testing Categorizes an issue or PR as relevant to SIG Testing. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 4, 2022
@dobsonj dobsonj force-pushed the kep-596-ga-feature-flag branch from 5b1d678 to 965446c Compare Aug 4, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 4, 2022
@dobsonj
Copy link
Member Author

dobsonj commented Aug 4, 2022

Last push rebases to resolve a merge conflict, adds e2e tests to be promoted to conformance, and removes one more reference to this as a beta feature.
Latest test failures appear unrelated:

Kubernetes e2e suite: [It] [sig-node] Probing container should mark readiness on pods to false while pod is in progress of terminating when a pod has a readiness probe expand_more

k8s.io/kubernetes/test/integration/daemonset: TestDSCUpdatesPodLabelAfterDedupCurHistories 

Kubernetes e2e suite: [It] [sig-network] Services should fail health check node port if there are only terminating endpoints [Feature:ProxyTerminatingEndpoints] expand_more

/retest

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 4, 2022
@dobsonj dobsonj force-pushed the kep-596-ga-feature-flag branch from 965446c to 5872eb5 Compare Aug 4, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 4, 2022
@dobsonj
Copy link
Member Author

dobsonj commented Aug 4, 2022

Last test run was clean, but had to rebase again for conflicts in strategy.go and strategy_test.go.

@dobsonj dobsonj force-pushed the kep-596-ga-feature-flag branch from 5872eb5 to 4c59416 Compare Aug 4, 2022
@dobsonj dobsonj force-pushed the kep-596-ga-feature-flag branch from 4c59416 to 0ee8fed Compare Aug 4, 2022
@msau42
Copy link
Member

msau42 commented Aug 5, 2022

/lgtm
/approve

Thanks for adding the new test!

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2022
@dobsonj
Copy link
Member Author

dobsonj commented Aug 5, 2022

API changes lgtm as well. once the functional part of this has lgtm, readd me and I'll tag for API approval

/assign @liggitt
for API approval

@liggitt
Copy link
Member

liggitt commented Aug 5, 2022

/approve
for API change

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj, liggitt, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2022
@cici37
Copy link
Contributor

cici37 commented Aug 5, 2022

Hello 👋, 1.25 Release Lead here.

The exception request is approved and your updated deadline to make any changes to your PR is 9:00 AM PST Monday 8th August 2022. Thank you!

/milestone v1.25

@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Aug 5, 2022
@k8s-ci-robot k8s-ci-robot merged commit 64ed914 into kubernetes:master Aug 5, 2022
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
API Reviews
API review completed, 1.25
Development

Successfully merging this pull request may close these issues.

None yet

7 participants