-
Notifications
You must be signed in to change notification settings - Fork 39.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean shutdown of serviceaccount integration tests #111325
Clean shutdown of serviceaccount integration tests #111325
Conversation
@wojtek-t: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
verify failure is legit |
76118f5
to
5af0866
Compare
@aojea - fixed, PTAL |
/retest |
1 similar comment
/retest |
/lgtm |
externalInformers = clientinformers.NewSharedInformerFactory(externalRootClientset, controller.NoResyncPeriodFunc()) | ||
informers = clientinformers.NewSharedInformerFactory(rootClientset, controller.NoResyncPeriodFunc()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this pattern in other tests, what is the external
suffix here meaning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH I'm not really sure those are needed.
I think that for separate clients the reason might have been separate QPS limit, but I don't think we need separate informers.
But I wanted to make those migration PRs as no-op as possible (hence decided not to touch many places that I believe can be further simplified).
Ref #108483
/kind cleanup
/priority important-longterm
/sig cloud-provider