-
Notifications
You must be signed in to change notification settings - Fork 39.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update kubectl kustomize to kyaml/v0.13.9, cmd/config/v0.10.9, api/v0.12.1, kustomize/v4.5.7 #111606
Conversation
/cc @kubernetes/dep-approvers |
0c278e8
to
3abc404
Compare
vendor/sigs.k8s.io/kustomize/kyaml/filesys/fsondisk_test_unix.go
Outdated
Show resolved
Hide resolved
vendor/sigs.k8s.io/kustomize/kyaml/filesys/fsondisk_test_windows.go
Outdated
Show resolved
Hide resolved
3abc404
to
a9613e5
Compare
/approve the dependency changes themselves looks good (did not add any new ones, some SHA's were moved to specific tags etc) |
/label tide/merge-method-squash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
@@ -36,7 +36,7 @@ import ( | |||
) | |||
|
|||
// TODO(knverey): remove this hardcoding once kubectl being built with module support makes BuildInfo available. | |||
const kustomizeVersion = "v4.5.4" | |||
const kustomizeVersion = "v4.5.7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
non-blocking for this PR, but our build is now building in module mode, so I think this TODO can be resolved (in a separate PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI @KnVerey
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, liggitt, natasha41575 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
….12.1, kustomize/v4.5.7
f14dfcd
to
4055c87
Compare
/triage accepted |
/lgtm |
/retest |
What type of PR is this?
/kind bug
/sig cli
/priority important-soon
What this PR does / why we need it:
This upgrades kustomize-in-kubectl to v4.5.7.
Special notes for your reviewer:
This is a go.mod change to upgrade the kustomize
dependency to v4.5.7.
Does this PR introduce a user-facing change?
How was this PR made?