e2e: ginkgo timeouts: use context provided by ginkgo #112923
Merged
+11,491
−11,371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
area/apiserver
area/cloudprovider
area/code-generation
area/dependency
pohly
force-pushed
the
e2e-ginkgo-timeouts
branch
from
87a1701
to
3415e13
Compare
pohly
force-pushed
the
e2e-ginkgo-timeouts
branch
from
3415e13
to
4e541d2
Compare
|
@pohly: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
All code must use the context from Ginkgo when doing API calls or polling for a change, otherwise the code would not return immediately when the test gets aborted.
pohly
force-pushed
the
e2e-ginkgo-timeouts
branch
from
de45c39
to
2f6c4f5
Compare
|
/retest |
|
/retest "pull-kubernetes-e2e-capz-windows-containerd — Pod pending timeout" |
|
I tried my best to get to all files but there are 418 files changes, that is impossible, most of them are mechanical changes s/context.TODO/context gingo/ and we can always revert. I think that merging on weekend will give us some soak time to see if something breaks, so we can revert in that case /lgtm e2e framework should be able to stop cleanly |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
🙌 |
This was referenced Dec 18, 2022
ivelichkovich
pushed a commit
to ivelichkovich/kubernetes
that referenced
this pull request
Dec 20, 2022
This is in preparation for kubernetes#112923: DeferCleanup will automatically do the right thing when testCleanup gets changed to require a context parameter.
jaehnri
pushed a commit
to jaehnri/kubernetes
that referenced
this pull request
Jan 3, 2023
This is in preparation for kubernetes#112923: DeferCleanup will automatically do the right thing when testCleanup gets changed to require a context parameter.
4 tasks
k8s-ci-robot
pushed a commit
that referenced
this pull request
May 2, 2023
* Fix flaky HPA e2e tests by not failing on context cancelled Consume requests are sent during test execution in a loop in a separate goroutine. Once the test completes, it is expected that a consumption request may be pending. Cancelling the request during cleanup should not cause test failures. Tests started being flaky since #112923 introduced passing test context that gets cancelled during cleanup. * Use PollUntilContextTimeout and restructure error ignoring logic
rayowang
pushed a commit
to rayowang/kubernetes
that referenced
this pull request
Feb 9, 2024
…es#117669) * Fix flaky HPA e2e tests by not failing on context cancelled Consume requests are sent during test execution in a loop in a separate goroutine. Once the test completes, it is expected that a consumption request may be pending. Cancelling the request during cleanup should not cause test failures. Tests started being flaky since kubernetes#112923 introduced passing test context that gets cancelled during cleanup. * Use PollUntilContextTimeout and restructure error ignoring logic
jkyros
pushed a commit
to jkyros/kubernetes
that referenced
this pull request
Apr 30, 2024
…ancelled (kubernetes#117669) * Fix flaky HPA e2e tests by not failing on context cancelled Consume requests are sent during test execution in a loop in a separate goroutine. Once the test completes, it is expected that a consumption request may be pending. Cancelling the request during cleanup should not cause test failures. Tests started being flaky since kubernetes#112923 introduced passing test context that gets cancelled during cleanup. * Use PollUntilContextTimeout and restructure error ignoring logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Ginkgo can tell code to stop running by canceling the context that Ginkgo provides to callbacks when those accept one. This can be used to stop immediately when aborting manually via CTRL-C and to clean up properly in case of a timeout, because cleanup code then runs after the main test has stopped with a new context.
Special notes for your reviewer:
I started eliminating context.TODO in provisioning.go and then branched out from there: any function which had context.TODO needed an explicit context. The minimal goal for this PR is to clean up all code in test/e2e/framework because then further PRs probably can be more localized.
Does this PR introduce a user-facing change?