Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-13392: UPSTREAM: 118915: remove legacy NetworkPolicy tests #1623

Merged
merged 2 commits into from Jul 6, 2023
Merged

OCPBUGS-13392: UPSTREAM: 118915: remove legacy NetworkPolicy tests #1623

merged 2 commits into from Jul 6, 2023

Conversation

npinaeva
Copy link
Member

@npinaeva npinaeva commented Jul 4, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

Disable legacy tests that started failing because of the timeout change kubernetes#112923

Which issue(s) this PR fixes:

Fixes #https://issues.redhat.com/browse/OCPBUGS-13392

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Upstream PR kubernetes#118915

@astoycos @npinaeva
UPSTREAM: 118915: remove legacy NetworkPolicy tests
ee62a22 
This commit removes the legacy networkpolicy tests since they now have
complete appropriate coverage in the new netpol suite.

Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
(cherry picked from commit 84b3d9b)
@openshift-ci-robot openshift-ci-robot added backports/validated-commits Indicates that all commits come to merged upstream PRs. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jul 4, 2023
@openshift-ci-robot
Copy link

@npinaeva: This pull request references Jira Issue OCPBUGS-13392, which is invalid:

  • expected the bug to target the "4.14.0" version, but it targets "4.14" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:

Disable legacy tests that started failing because of the timeout change kubernetes#112923

Which issue(s) this PR fixes:

Fixes #https://issues.redhat.com/browse/OCPBUGS-13392

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Upstream PR kubernetes#118915

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jul 4, 2023
@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 4, 2023
@openshift-ci-robot
Copy link

@npinaeva: the contents of this pull request could be automatically validated.

The following commits are valid:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot requested review from mfojtik and soltysh July 4, 2023 15:56
@npinaeva
Copy link
Member Author

npinaeva commented Jul 4, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 4, 2023
@openshift-ci-robot
Copy link

@npinaeva: This pull request references Jira Issue OCPBUGS-13392, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@npinaeva
Copy link
Member Author

npinaeva commented Jul 5, 2023

/retest-required

@npinaeva
UPSTREAM: <drop>: make update
b06b0c3 
Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com>
@openshift-ci-robot openshift-ci-robot added backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. and removed backports/validated-commits Indicates that all commits come to merged upstream PRs. labels Jul 5, 2023
@openshift-ci-robot
Copy link

@npinaeva: the contents of this pull request could not be automatically validated.

The following commits are valid:

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

soltysh
soltysh approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/remove-label backports/unvalidated-commits
/label backports/validated-commits

@openshift-ci openshift-ci bot added backports/validated-commits Indicates that all commits come to merged upstream PRs. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Jul 5, 2023
@soltysh
Copy link
Member

soltysh commented Jul 5, 2023

/test unit

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: npinaeva, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e8b13aa and 2 for PR HEAD b06b0c3 in total

@openshift-ci
Copy link

openshift-ci bot commented Jul 5, 2023 •
edited

@npinaeva: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-ovn-cmd b06b0c3 link false /test e2e-agnostic-ovn-cmd

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@npinaeva
Copy link
Member Author

npinaeva commented Jul 5, 2023

gcp failure looks like https://issues.redhat.com/browse/OCPBUGS-15804

@npinaeva
Copy link
Member Author

npinaeva commented Jul 6, 2023

/retest-required

@openshift-merge-robot openshift-merge-robot merged commit 879a9e7 into openshift:master Jul 6, 2023
18 of 19 checks passed
@openshift-ci-robot
Copy link

@npinaeva: Jira Issue OCPBUGS-13392: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-13392 has been moved to the MODIFIED state.

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:

Disable legacy tests that started failing because of the timeout change kubernetes#112923

Which issue(s) this PR fixes:

Fixes #https://issues.redhat.com/browse/OCPBUGS-13392

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Upstream PR kubernetes#118915

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@npinaeva npinaeva deleted the ocpbugs-13392 branch July 6, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@mfojtik mfojtik Awaiting requested review from mfojtik

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@npinaeva @openshift-ci-robot @soltysh @openshift-merge-robot @astoycos