Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Spawn poststart / prestop pods on the same node as the https pod #113597

Merged
merged 1 commit into from Nov 9, 2022
Merged

tests: Spawn poststart / prestop pods on the same node as the https pod #113597

merged 1 commit into from Nov 9, 2022
+10 −2

Conversation

ionutbalutoiu
Copy link
Contributor

What type of PR is this?

/kind flake
/sig testing
/sig networking

/priority important-soon

What this PR does / why we need it:

In the PR #86139, two more lifecycle hook tests (poststart / prestop) were added using HTTPS.
They are similar with the existing HTTP tests.

However, this causes failures on Windows due to how networking works there.
We previously fixed this in the HTTP tests via f9e4a01.

This commit applies the same fix on the lifecycle hook HTTPS tests.

Which issue(s) this PR fixes:

Fixes #113479

Special notes for your reviewer:

Flakes:

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-kubernetes-e2e-capz-master-containerd-windows/1588164032907448320
https://prow.k8s.io/view/gs/k8s-ovn/logs/k8s-e2e-ltsc2019-containerd-flannel-sdnoverlay-master/1587867149295161344

Not flaking:

https://prow.k8s.io/view/gs/k8s-ovn/logs/k8s-e2e-ltsc2019-containerd-flannel-sdnbridge-stable/1587972846427049984

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@ionutbalutoiu
tests: Spawn poststart / prestop pods on the same node as the https pod
f092343 
In the PR kubernetes#86139, two more lifecycle hook tests (poststart / prestop)
were added using HTTPS. They are similar with the existing HTTP tests.

However, this causes failures on Windows due to how networking
works there. We previously fixed this in the HTTP tests via kubernetes@f9e4a01.

This commit applies the same fix on the lifecycle hook HTTPS tests.

Signed-off-by: Ionut Balutoiu <ibalutoiu@cloudbasesolutions.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/flake Categorizes issue or PR as related to a flaky test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Nov 3, 2022
@k8s-ci-robot
Copy link
Contributor

@ionutbalutoiu: The label(s) sig/networking cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind flake
/sig testing
/sig networking

/priority important-soon

What this PR does / why we need it:

In the PR #86139, two more lifecycle hook tests (poststart / prestop) were added using HTTPS.
They are similar with the existing HTTP tests.

However, this causes failures on Windows due to how networking works there.
We previously fixed this in the HTTP tests via f9e4a01.

This commit applies the same fix on the lifecycle hook HTTPS tests.

Which issue(s) this PR fixes:

Fixes #113479

Special notes for your reviewer:

Flakes:

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-kubernetes-e2e-capz-master-containerd-windows/1588164032907448320
https://prow.k8s.io/view/gs/k8s-ovn/logs/k8s-e2e-ltsc2019-containerd-flannel-sdnoverlay-master/1587867149295161344

Not flaking:

https://prow.k8s.io/view/gs/k8s-ovn/logs/k8s-e2e-ltsc2019-containerd-flannel-sdnbridge-stable/1587972846427049984

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 3, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @ionutbalutoiu!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @ionutbalutoiu. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/test sig/node Categorizes an issue or PR as relevant to SIG Node. labels Nov 3, 2022
@ionutbalutoiu ionutbalutoiu mentioned this pull request Nov 3, 2022
Closed
@jsturtevant
Copy link
Contributor

/sig windows
/triage accepted

@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 3, 2022
@jsturtevant
Copy link
Contributor

/cc @marosset

@marosset
Copy link
Contributor

marosset commented Nov 3, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 3, 2022
@marosset
Copy link
Contributor

marosset commented Nov 3, 2022

/milestone v1.26

@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Nov 3, 2022
@aojea
Copy link
Member

aojea commented Nov 3, 2022

/assign @claudiubelu

@matthyx
Copy link
Contributor

matthyx commented Nov 4, 2022

/uncc

@k8s-ci-robot k8s-ci-robot removed the request for review from matthyx November 4, 2022 10:30
@marosset
Copy link
Contributor

marosset commented Nov 7, 2022

/retest
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2022
@jsturtevant
Copy link
Contributor

/assign @SergeyKanzhelev @derekwaynecarr

@marosset
Copy link
Contributor

marosset commented Nov 8, 2022

/assign @endocrimes
This PR is applying fixes that addressed the same issue in similar tests previously.

@claudiubelu
Copy link
Contributor

Indeed, we have solved this issue for HTTP some time ago, and the same issue and the same solution is needed for HTTPS as well.

/lgtm

@xmudrii
Copy link
Member

xmudrii commented Nov 9, 2022

We should cherry-pick this PR to the release-1.25 branch once it's merged. Ref: #113479 (comment)

@leonardpahlke leonardpahlke removed this from the v1.26 milestone Nov 9, 2022
@leonardpahlke
Copy link
Member

/milestone v1.26

@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Nov 9, 2022
@marosset
Copy link
Contributor

marosset commented Nov 9, 2022

/assign @aojea

endocrimes
endocrimes approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@endocrimes endocrimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thanks and sorry for the delay!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: endocrimes, ionutbalutoiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2022
@SergeyKanzhelev SergeyKanzhelev moved this from Triage to Done in SIG Node CI/Test Board Nov 9, 2022
@k8s-ci-robot k8s-ci-robot merged commit 8eddcac into kubernetes:master Nov 9, 2022
SIG Node PR Triage automation moved this from Triage to Done Nov 9, 2022
@ionutbalutoiu ionutbalutoiu deleted the tests/lifecycle-hooks branch November 10, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endocrimes endocrimes endocrimes approved these changes

@mtaufen mtaufen Awaiting requested review from mtaufen

@marosset marosset Awaiting requested review from marosset

Assignees

@endocrimes endocrimes

@claudiubelu claudiubelu

@derekwaynecarr derekwaynecarr

@aojea aojea

@SergeyKanzhelev SergeyKanzhelev

@marosset marosset

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Archived in project
[sig-release] Bug Triage
Archived in project
[sig-windows] PR tracking
Status: Done
SIG Node PR Triage
Done
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

[Failing test] capz-windows-containerd-master