Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a flag to HNS Load Balancer policy to hint HNS about the VIP being an External IP #113742

Merged
merged 1 commit into from
Dec 12, 2022
Merged

Add a flag to HNS Load Balancer policy to hint HNS about the VIP being an External IP #113742

merged 1 commit into from
Dec 12, 2022

Conversation

princepereira
Copy link
Contributor

@princepereira princepereira commented Nov 8, 2022 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

For Service of Type Load Balancer and External Traffic Policy set to Local add a new Portmapping flag to the HNS Load Balancer policy which ensures that once a connection is directed to an endpoint, it continues to go to that endpoint despite changes in the list of endpoints backing the service.

Fixing issue in Winkernel Proxier - Unexpected active TCP connection drops while horizontally scaling the endpoints for a LoadBalancer Service with Internal Traffic Policy: Local

Which issue(s) this PR fixes:

#113842

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 8, 2022
@k8s-ci-robot
Copy link
Contributor

@princepereira: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 8, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @princepereira. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Nov 8, 2022
@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 8, 2022
@princepereira princepereira force-pushed the ppereira-kubeproxy-flags branch 2 times, most recently from f17c041 to 0daf00c Compare November 9, 2022 08:21
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 9, 2022
@princepereira princepereira changed the title Creating Ingress IP loadbalancer alone when all the endpoints are teminating Introducing LoadbalancerPortMapping flags for VipExternalIP Nov 9, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Nov 9, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Nov 10, 2022
@princepereira princepereira force-pushed the ppereira-kubeproxy-flags branch 2 times, most recently from e82de8d to 974f77e Compare November 10, 2022 04:06
@sbangari
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 11, 2022
@princepereira
Copy link
Contributor Author

/cc @jsturtevant
/cc @daschott
/cc @sbangari

Hi @jsurtevant, @daschott , @sbangari ,

Please review the code when you get some time.

Regards,
Prince

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2022
@princepereira
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-ubuntu-containerd

1 similar comment
@princepereira
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-ubuntu-containerd

This was referenced Nov 21, 2022
Merged
Merged
Merged
@sbangari
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2022
@marosset
Copy link
Contributor

/milestone v1.27

@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Nov 28, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2022
@sbangari
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2022
@princepereira
Copy link
Contributor Author

/test pull-kubernetes-integration

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit 0e19bbb into kubernetes:master Dec 12, 2022
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.27, v1.26 Dec 12, 2022
@marosset
Copy link
Contributor

/sig windows
/milestone v1.27

@k8s-ci-robot k8s-ci-robot added the sig/windows Categorizes an issue or PR as relevant to SIG Windows. label Dec 12, 2022
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.26, v1.27 Dec 12, 2022
@princepereira princepereira mentioned this pull request Dec 14, 2022
Closed
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 14, 2022
k8s-ci-robot added a commit that referenced this pull request Dec 16, 2022
@k8s-ci-robot
Merge pull request #114040 from princepereira/automated-cherry-pick-o…
d492b15 
…f-#113742-upstream-release-1.24

Automated cherry pick of #113742: Introducing LoadbalancerPortMapping flags for VipExternalIP
k8s-ci-robot added a commit that referenced this pull request Dec 16, 2022
@k8s-ci-robot
Merge pull request #114038 from princepereira/automated-cherry-pick-o…
c7118d9 
…f-#113742-upstream-release-1.26

[1.26.1] Automated cherry pick of #113742: Introducing LoadbalancerPortMapping flags for VipExternalIP
k8s-ci-robot added a commit that referenced this pull request Dec 16, 2022
@k8s-ci-robot
Merge pull request #114039 from princepereira/automated-cherry-pick-o…
24fbafc 
…f-#113742-upstream-release-1.25

Automated cherry pick of #113742: Introducing LoadbalancerPortMapping flags for VipExternalIP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschott daschott daschott requested changes

@feiskyer feiskyer Awaiting requested review from feiskyer

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

@sbangari sbangari Awaiting requested review from sbangari

Assignees

@sbangari sbangari

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.
6 participants
@princepereira @k8s-ci-robot @sbangari @marosset @k8s-triage-robot @daschott