Fix discovering numa distance when node ids are not starting from 0 or it's ids are not sequential

[PiotrProkop]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #113781

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

Hi @PiotrProkop. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mkumatag]

/ok-to-test

[klueska]

/ok-to-test

[klueska]

/triage accepted
/priority critical-urgent

[klueska]

/approve
/lgtm

[klueska]

/milestone v1.26

[klueska]

/cc dchen1107 derekwaynecarr
This bug was introduced as part of #112914

It will cause the kubelet to crash on any system that has more than 1 NUMA node (i.e. almost any machine nowadays)

[PiotrProkop]

Just to clarify it will fail if NUMA nodes ids are not sequential e.g node0, node1 starting from 0 or if the single NUMA node on the system is not node0. I have added unit tests to cover those cases.

[liggitt]

I'll defer to node reviewers on this specific change, but I labeled the bug as a regression/release-blocker and added it to the milestone

[klueska]

Thanks @liggitt is that label / milestone not applicable to this PR itself? Or just the bug?

[liggitt]

Thanks @liggitt is that label / milestone not applicable to this PR itself? Or just the bug?

if this is accepted as the fix, it will be added to this PR (that's what I'm deferring to node folks on)

[dims]

bug in alpha feature that did not get caught in our CI jobs. we need this in 1.26 itself!

/milestone v1.26

[dims]

thanks @PiotrProkop

[klueska]

if this is accepted as the fix, it will be added to this PR (that's what I'm deferring to node folks on)

Great, thanks. Yes. I have already approved it as a sig-node-approver:
https://github.com/kubernetes/kubernetes/blob/master/OWNERS_ALIASES#L222...L229

[mkumatag]

bug in alpha feature that did not get caught in our CI jobs. we need this in 1.26 itself!

/milestone v1.26

well, we didn't enable any alpha feature gates.. this was just happening in our regular CI test on ppc64le platform with single NUMA node(with id 1)

[PiotrProkop]

/hold
I will add a check not to discover NUMA distance, if proper topology-option is not set, just to be double sure.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: klueska, PiotrProkop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/kubelet/cm/cpumanager/OWNERS [klueska]
• pkg/kubelet/cm/topologymanager/OWNERS [klueska]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[klueska]

@PiotrProkop Thanks for the update.

Now that the cadvisor update has landed this is much cleaner and much more protected behind the feature gate.

/lgtm

[PiotrProkop]

Thanks, for the review.
/unhold

[PiotrProkop]

/retest
The error seems unrelated:

Nov  9 17:22:21.469: INFO: Waiting 10s to retry failed RunHostCmd: error running /home/prow/go/src/k8s.io/kubernetes/_output/bin/kubectl --server=https://127.0.0.1:35701/ --kubeconfig=/root/.kube/kind-test-config --namespace=statefulset-6261 exec ss-1 -- /bin/sh -x -c mv -v /tmp/index.html /usr/local/apache2/htdocs/ || true:
        Command stdout:
        stderr:
        Error from server (NotFound): pods "ss-1" not found
        error:
        exit status 1