Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor mock tests in different files #113930

Merged
merged 2 commits into from
Dec 14, 2022
Merged

Refactor mock tests in different files #113930

merged 2 commits into from
Dec 14, 2022

Conversation

gnufied
Copy link
Member

@gnufied gnufied commented Nov 15, 2022

CSI mock tests are becoming this bag of functions which are ever expanding in same file.

Lets split them according to features they are testing.

/sig storage

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. sig/storage Categorizes an issue or PR as relevant to SIG Storage. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 15, 2022
@k8s-ci-robot
Copy link
Contributor

@gnufied: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 15, 2022
@gnufied
Copy link
Member Author

gnufied commented Nov 15, 2022

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 15, 2022
@gnufied
Copy link
Member Author

gnufied commented Nov 15, 2022

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 15, 2022
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 15, 2022
@jsafrane
Copy link
Member

I checked the same CSI Mock tests are running in this PR as it was before + the tests look roughly the same (m. was added to all init/cleanup/createPod and other calls)
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2022
@gnufied
Copy link
Member Author

gnufied commented Nov 28, 2022

/assign @pohly

@gnufied
Copy link
Member Author

gnufied commented Nov 28, 2022

/assign @msau42

@pohly
Copy link
Contributor

pohly commented Nov 28, 2022

/hold

Can we please merge #112923 first? That PR was pushed back to go in as soon as the branch reopens, but it will conflict with almost any other PR that touches E2E tests.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 28, 2022
@gnufied
Copy link
Member Author

gnufied commented Nov 30, 2022

yeah that seems fine. Do we have necessary lgtms and approvals on other PR though?

@pohly
Copy link
Contributor

pohly commented Dec 1, 2022

Not yet, but there was a general agreement that it should go in. We just need to formalize that and then hit a time period where there no merge conflicts that would require a rebase and thus invalidate the lgtm.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2022
@gnufied gnufied mentioned this pull request Dec 5, 2022
Merged
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 11, 2022
@dims
Copy link
Member

dims commented Dec 12, 2022

If you still need this PR then please rebase, if not, please close the PR

@gnufied
Copy link
Member Author

gnufied commented Dec 12, 2022 •
edited

I still need this PR. But I am waiting for #112923 to land first, so as it does not cause unnecessary conflicts for @pohly

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 13, 2022
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 13, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 13, 2022
pohly
pohly approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2022
@pohly
Copy link
Contributor

pohly commented Dec 13, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2022
@pohly
Copy link
Contributor

pohly commented Dec 13, 2022

/assign @jsafrane

For approval.

@gnufied
Copy link
Member Author

gnufied commented Dec 13, 2022

/retest

@msau42
Copy link
Member

msau42 commented Dec 13, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, jsafrane, msau42, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit 546d405 into kubernetes:master Dec 14, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pohly pohly pohly approved these changes

@lavalamp lavalamp Awaiting requested review from lavalamp

@mattcary mattcary Awaiting requested review from mattcary

Assignees

@pohly pohly

@jsafrane jsafrane

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@gnufied @k8s-ci-robot @jsafrane @pohly @dims @msau42