-
Notifications
You must be signed in to change notification settings - Fork 39.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use python3 in hack #114976
use python3 in hack #114976
Conversation
@kidddddddddddddddddddddd: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @kidddddddddddddddddddddd. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of these required any source changes?
Yesterday I just ran these files with python3 locally, and everything was fine.
I'd be glad to receive some suggestions about how to check this more properly :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
Thanks! I stumbled on this in my own work. Anything holding up approval? |
Actually I don't know. Maybe you can read the statement and give me some advice. |
I'm not at all a python expert, I just know that I don't have python2 installed :) This looks OK to me, but I can't say I know what all the diffs are about. |
This is a good start, let's get this in and see if we find any other problems. (Yes, i've dabbled with this python2->3 migration before, the automated thing finds a lot of it for sure, but it may not catch 100% of things) /approve |
LGTM label has been added. Git tree hash: c5658ca785b9b4bc3693baf2fcba42b201348d75
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, kidddddddddddddddddddddd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you! |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Currently some files in k/k are still using python2, we should upgrade them to python3.
Which issue(s) this PR fixes:
Fixes #114967
Special notes for your reviewer:
I ran this command to find py files in k/k repo:
I ran this script to update and check these py files:
please leave a comment if there's a more appropriate method :)
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: