Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use python3 in hack #114976

Merged
merged 1 commit into from
Jan 19, 2023
Merged

use python3 in hack #114976

merged 1 commit into from
Jan 19, 2023

Conversation

AxeZhan
Copy link
Member

@AxeZhan AxeZhan commented Jan 11, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

Currently some files in k/k are still using python2, we should upgrade them to python3.

Which issue(s) this PR fixes:

Fixes #114967

Special notes for your reviewer:

I ran this command to find py files in k/k repo:

find ./ -name "*.py"                  
.//staging/src/k8s.io/kubectl/pkg/util/i18n/translations/extract.py
.//hack/boilerplate/test/pass.py
.//hack/boilerplate/test/fail.py
.//hack/boilerplate/boilerplate.py
.//hack/boilerplate/boilerplate_test.py
.//hack/verify-flags-underscore.py
.//hack/verify-publishing-bot.py

I ran this script to update and check these py files:

#!/usr/bin/env python
import sys
from lib2to3.main import main

sys.exit(main("lib2to3.fixes"))

please leave a comment if there's a more appropriate method :)

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 11, 2023
@k8s-ci-robot
Copy link
Contributor

@kidddddddddddddddddddddd: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 11, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @kidddddddddddddddddddddd. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jan 11, 2023
@k8s-ci-robot k8s-ci-robot added area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 11, 2023
@aojea
Copy link
Member

aojea commented Jan 11, 2023

/ok-to-test
/assign @BenTheElder

Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of these required any source changes?

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 12, 2023
@AxeZhan
Copy link
Member Author

AxeZhan commented Jan 12, 2023

None of these required any source changes?

Yesterday I just ran these files with python3 locally, and everything was fine.
Today I ran a script to check these files, and it shows some changes.

#!/usr/bin/env python
import sys
from lib2to3.main import main

sys.exit(main("lib2to3.fixes"))

I'd be glad to receive some suggestions about how to check this more properly :)

@AxeZhan AxeZhan requested review from BenTheElder and removed request for seans3 and dchen1107 January 12, 2023 03:24
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 12, 2023
@thockin
Copy link
Member

thockin commented Jan 19, 2023

Thanks! I stumbled on this in my own work. Anything holding up approval?

@AxeZhan
Copy link
Member Author

AxeZhan commented Jan 19, 2023

Thanks! I stumbled on this in my own work. Anything holding up approval?

Actually I don't know. Maybe you can read the statement and give me some advice.

@thockin
Copy link
Member

thockin commented Jan 19, 2023

I'm not at all a python expert, I just know that I don't have python2 installed :)

This looks OK to me, but I can't say I know what all the diffs are about.

@dims
Copy link
Member

dims commented Jan 19, 2023

This is a good start, let's get this in and see if we find any other problems.

(Yes, i've dabbled with this python2->3 migration before, the automated thing finds a lot of it for sure, but it may not catch 100% of things)

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 19, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c5658ca785b9b4bc3693baf2fcba42b201348d75

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, kidddddddddddddddddddddd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2023
@k8s-ci-robot k8s-ci-robot merged commit 6b55f09 into kubernetes:master Jan 19, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Jan 19, 2023
@BenTheElder
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python2 still in use
6 participants