Validate format of timeZone before calling system LoadLocation method

[liggitt]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Adds format validation of time zones ahead of calling the LoadLocation system-dependent method.

This insulates us from platform differences in handling of edge case values (xref #114508 (review))

A unit test ensuring all listed IANA time zones pass this validation is added.

Updates of CronJobs which do not change time zone values are already tolerated.

Which issue(s) this PR fixes:

Makes CronJob validation behavior more consistent across platforms.

Does this PR introduce a user-facing change?

NONE

cc @soltysh @claudiubelu

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/apis/OWNERS [liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[claudiubelu]

It seems there are a few cases which are failing:

{Failed  === RUN   TestTimeZones
    validation_test.go:2789: America/Ciudad_Juarez failed: [<nil>: Invalid value: "America/Ciudad_Juarez": unknown time zone America/Ciudad_Juarez]
    validation_test.go:2789: Europe/Kyiv failed: [<nil>: Invalid value: "Europe/Kyiv": unknown time zone Europe/Kyiv]
--- FAIL: TestTimeZones (0.18s)

[claudiubelu]

/test pull-ci-kubernetes-unit-windows

[pacoxu]

validation_test.go:2789: America/Ciudad_Juarez failed: [: Invalid value: "America/Ciudad_Juarez": unknown time zone America/Ciudad_Juarez]
validation_test.go:2789: Europe/Kyiv failed: [: Invalid value: "Europe/Kyiv": unknown time zone Europe/Kyiv]

The test failed on Linux and passed on Mac.

[pacoxu]

root@16a10d869e1f:/usr/src/kubernetes# cat /usr/local/go/src/time/zoneinfo_test.go | grep TestBadLocationErrMsg -A 10
func TestBadLocationErrMsg(t *testing.T) {
        time.ResetZoneinfoForTesting()
        loc := "Europe/Kyiv"
        want := errors.New("unknown time zone " + loc)
        _, err := time.LoadLocation(loc)
        if err.Error() == want.Error() {
                t.Errorf("LoadLocation(%q) error = %v; want %v", loc, err, want)
        }
}

func TestLoadLocationValidatesNames(t *testing.T) {
root@16a10d869e1f:/usr/src/kubernetes# /usr/local/go/bin/go test -timeout 30s -run ^TestBadLocationErrMsg$ time
--- FAIL: TestBadLocationErrMsg (0.00s)
    zoneinfo_test.go:46: LoadLocation("Europe/Kyiv") error = unknown time zone Europe/Kyiv; want unknown time zone Europe/Kyiv
FAIL
FAIL    time    0.003s
FAIL

The reason seems to be that America/Ciudad_Juarez and Europe/Kyiv are valid on Mac and not Valid in linux.

[pacoxu]

America/Ciudad_Juarez
http://mm.icann.org/pipermail/tz-announce/2022-November/000076.html

• A new Zone America/Ciudad_Juarez splits from America/Ojinaga. It was added recently.

Europe/Kyiv
The suggestion to rename the time zone ID Europe/Kiev to Europe/Kyiv has been made and accepted! The change was introduced in release 2022b (Released 2022-08-11).
It can be found in https://data.iana.org/time-zones/tzdb-2022b/backward.

[liggitt]

The reason seems to be that America/Ciudad_Juarez and Europe/Kyiv are valid on Mac and not Valid in linux.

those were added after go1.19 was released, pruned the unit test to just valid timezones as of go1.19 release, and imported "time/tzdata" to the unit test to mitigate cross-platform differences

[liggitt]

/test pull-ci-kubernetes-unit-windows

[pacoxu]

/lgtm
/assign @claudiubelu

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 0bd154075557473648178cf7082c6ea85db304e0

[liggitt]

Unit tests passed on Mac, windows, and Linux