Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #112806: test: demote service ClientIP affinity timeout tests from #115510

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Automated cherry pick of #112806: test: demote service ClientIP affinity timeout tests from #115510

merged 1 commit into from
Apr 4, 2023

Conversation

abhat
Copy link

@abhat abhat commented Feb 3, 2023

Cherry pick of #112806 on release-1.24.

#112806: test: demote service ClientIP affinity timeout tests from

For details on the cherry pick process, see the cherry pick requests page.

@dcbw @abhat
test: demote service ClientIP affinity timeout tests from conformance
50f819c 
During the September 29th, 2022 SIG-Network meeting we decided to
demote the two affinity timeout conformance tests. This was because:

(a) there is no documented correct behavior for these tests other than
"what kube-proxy does"
(b) even the kube-proxy behavior differs depending on the backend implementation
of iptables, IPVS, or [win]userspace (and winkernel doesn't at all)
(c) iptables uses only srcip matching, while userspace and IPVS use srcip+srcport
(d) IPVS and iptables have different minimum timeouts and we had
to hack up the test itself to make IPVS pass
(e) popular 3rd party network plugins also vary in their implementation

Our plan is to deprecate the current affinity options and re-add specific
options for various behaviors so it's clear exactly what plugins support
and which behavior (if any) we want to require for conformance in the future.

Signed-off-by: Dan Williams <dcbw@redhat.com>
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Feb 3, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 3, 2023
@k8s-ci-robot
Copy link
Contributor

@abhat: Adding label: do-not-merge/blocked-paths because PR changes a protected file.

Reasons for blocking this PR:

[test/conformance/testdata/conformance.yaml cannot be updated on release branches.]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

This cherry pick PR is for a release branch and has not yet been approved by Release Managers.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved (/lgtm + /approve) by the relevant OWNERS.

AFTER it has been approved by code owners, please leave the following comment on a line by itself, with no leading whitespace: /cc kubernetes/release-managers

(This command will request a cherry pick review from Release Managers and should work for all GitHub users, whether they are members of the Kubernetes GitHub organization or not.)

For details on the patch release process and schedule, see the Patch Releases page.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 3, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @abhat. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Feb 3, 2023
@abhat
Copy link
Author

abhat commented Feb 3, 2023

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Feb 3, 2023
@k8s-ci-robot k8s-ci-robot added area/conformance Issues or PRs related to kubernetes conformance tests area/test sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 3, 2023
@abhat
Copy link
Author

abhat commented Feb 3, 2023

/assign @aojea

@abhat abhat mentioned this pull request Feb 6, 2023
Merged
@dcbw
Copy link
Member

dcbw commented Feb 7, 2023

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 7, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 701fbf9d9283a149e6791ad6c59d703647c8551d

@heyste
Copy link
Member

heyste commented Feb 13, 2023

/test pull-kubernetes-unit
Flake:

reconciler_test.go:1605: Check volume <fake-plugin/volume-name> is reported as attached to node <fail-detach-node>, got false, expected true

@riaankleinhans
Copy link
Contributor

@johnbelamaric this PR is the 1.24 version of #112990 and should then also be ok to merge.

@johnbelamaric
Copy link
Member

/approve

@abhat
Copy link
Author

abhat commented Feb 15, 2023

/assign @aojea

@aojea
Copy link
Member

aojea commented Mar 10, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2023
@abhat
Copy link
Author

abhat commented Mar 10, 2023

/cc kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested a review from a team March 10, 2023 23:35
@Verolop
Copy link

Verolop commented Mar 11, 2023

@abhat @aojea following the discussion on #112990 , are we good to merge without affecting Sonobuoy's side?
Both PRs still have the do-not-merge/blocked-paths tag. Happy to remove it manually once you confirm it's ok on your side (we're OK).

@abhat
Copy link
Author

abhat commented Mar 14, 2023

@heyste @Riaankl @johnbelamaric are we ok with getting the changes in #112990 and this PR merged without affecting Sonobuoy?

@riaankleinhans
Copy link
Contributor

@heyste @Riaankl @johnbelamaric are we ok with getting the changes in #112990 and this PR merged without affecting Sonobuoy?

The CNCF K8s Conformance submission policy allow for current release -2 releases.
Therefore v1.24 would not be supported for Conformance PR submissions by 11 April 2023.

@dims
Copy link
Member

dims commented Apr 4, 2023

/approve
/lgtm

ok to remove blocked-paths tags

(#112806 (comment))

xmudrii
xmudrii approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For RelEng:
/lgtm
/approve

@xmudrii xmudrii added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 4, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Apr 4, 2023
@xmudrii xmudrii removed the do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. label Apr 4, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhat, aojea, dims, johnbelamaric, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit cfda19f into kubernetes:release-1.24 Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

@MrHohn MrHohn Awaiting requested review from MrHohn

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@dims dims

@aojea aojea

@dcbw dcbw

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance Issues or PRs related to kubernetes conformance tests area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@abhat @k8s-ci-robot @dcbw @heyste @riaankleinhans @johnbelamaric @aojea @Verolop @dims @xmudrii