Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ctx logging involved in KS startup #115588

Merged
merged 5 commits into from
Feb 13, 2023
Merged

Add ctx logging involved in KS startup #115588

merged 5 commits into from
Feb 13, 2023

Conversation

knelasevero
Copy link
Contributor

@knelasevero knelasevero commented Feb 7, 2023 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

As per #111155 (review)

Only moved changes that touch startup or are changes that won't touch eventhandlers.go, schedule_one.go and pkg/scheduler/framework, pkg/scheduler/internal. I prefer to keep the bulk of the internal changes in that other PR.

Which issue(s) this PR fixes:

Related to #111155 and #91633

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 7, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Feb 7, 2023
@k8s-ci-robot k8s-ci-robot added area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 7, 2023
@knelasevero knelasevero mentioned this pull request Feb 7, 2023
Closed
knelasevero
knelasevero commented Feb 7, 2023
View reviewed changes
cmd/kube-scheduler/app/server.go Outdated
@@ -111,6 +111,7 @@ for more information about scheduling and the kube-scheduler component.`,
cliflag.SetUsageAndHelpFunc(cmd, *nfs, cols)

if err := cmd.MarkFlagFilename("config", "yaml", "yml", "json"); err != nil {
// nolint:logcheck // TODO (?): return error instead of logging it here
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving this discussion here: #111155 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's use klog.Background

@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

alculquicondor
alculquicondor reviewed Feb 10, 2023
View reviewed changes
cmd/kube-scheduler/app/options/configfile.go Show resolved Hide resolved
cmd/kube-scheduler/app/server.go Outdated
@@ -111,6 +111,7 @@ for more information about scheduling and the kube-scheduler component.`,
cliflag.SetUsageAndHelpFunc(cmd, *nfs, cols)

if err := cmd.MarkFlagFilename("config", "yaml", "yml", "json"); err != nil {
// nolint:logcheck // TODO (?): return error instead of logging it here
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's use klog.Background

pkg/scheduler/apis/config/v1/defaults.go Outdated Show resolved Hide resolved
pkg/scheduler/util/utils.go Show resolved Hide resolved
test/integration/scheduler_perf/main_test.go Outdated Show resolved Hide resolved
@knelasevero knelasevero mentioned this pull request Feb 13, 2023
Open
@knelasevero
Copy link
Contributor Author

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 13, 2023
alculquicondor
alculquicondor reviewed Feb 13, 2023
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/hold for nit

hack/logcheck.conf Outdated Show resolved Hide resolved
pkg/scheduler/apis/config/v1/defaults.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 13, 2023
@alculquicondor
Copy link
Member

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 13, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c90453db12d65ebfb3bcbe4dd3cf50d30b726129

@alculquicondor
Copy link
Member

@pohly can you self-nominate as an approver for hack?
In the meantime, can you recommend an approver that has the context (pun not intended) about these changes?

@pohly
Copy link
Contributor

pohly commented Feb 13, 2023

/assign @dims

For approval of logcheck changes.

I'll also create a PR to add myself to OWNERS.

@pohly pohly mentioned this pull request Feb 13, 2023
Merged
@dims
Copy link
Member

dims commented Feb 13, 2023

/approve

(hack/logcheck.conf looks good)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, dims, knelasevero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2023
@knelasevero knelasevero changed the title Add ctx logging involved in startup Add ctx logging involved in KS startup Feb 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit 6b34faf into kubernetes:master Feb 13, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Feb 13, 2023
@alculquicondor alculquicondor mentioned this pull request Feb 23, 2023
Closed
@knelasevero knelasevero mentioned this pull request Apr 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pohly pohly pohly left review comments

@alculquicondor alculquicondor alculquicondor left review comments

@chendave chendave Awaiting requested review from chendave

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees

@dims dims

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.
6 participants
@knelasevero @k8s-ci-robot @k8s-triage-robot @alculquicondor @pohly @dims