Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add SeccompProfile to Pod and Container accessors/mutators #115968

Merged
merged 1 commit into from
Mar 6, 2023
Merged

add SeccompProfile to Pod and Container accessors/mutators #115968

merged 1 commit into from
Mar 6, 2023

Conversation

stlaz
Copy link
Member

@stlaz stlaz commented Feb 22, 2023 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR adds the SeccompProfile field into the pod and container security context accessor/mutator to maintain the securityContext workflow.

Which issue(s) this PR fixes:

Related to #91286

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/cc @saschagrunert @tallclair
since you seem to have been active at the referenced issue

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Feb 22, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 22, 2023
saschagrunert
saschagrunert reviewed Feb 23, 2023
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/sig node

pkg/securitycontext/accessors.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 23, 2023
@bart0sh bart0sh added this to Triage in SIG Node PR Triage Feb 23, 2023
@bart0sh
Copy link
Contributor

bart0sh commented Feb 23, 2023

/triage accepted
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 23, 2023
@bart0sh bart0sh moved this from Triage to Needs Reviewer in SIG Node PR Triage Feb 23, 2023
@openshift-ci-robot openshift-ci-robot mentioned this pull request Feb 28, 2023
Merged
@bart0sh
Copy link
Contributor

bart0sh commented Mar 2, 2023

/assign @saschagrunert @tallclair

@bart0sh
Copy link
Contributor

bart0sh commented Mar 6, 2023

/assign @liggitt

@liggitt
Copy link
Member

liggitt commented Mar 6, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7fc7eb84a5046c6175cb6a08797aac679f312518

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, saschagrunert, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2023
@k8s-ci-robot k8s-ci-robot merged commit 388ad23 into kubernetes:master Mar 6, 2023
SIG Node PR Triage automation moved this from Needs Reviewer to Done Mar 6, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Mar 6, 2023
@openshift-ci-robot openshift-ci-robot mentioned this pull request Mar 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@tallclair tallclair Awaiting requested review from tallclair

Assignees

@saschagrunert saschagrunert

@liggitt liggitt

@tallclair tallclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@stlaz @bart0sh @liggitt @k8s-ci-robot @saschagrunert @tallclair