-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax the HPA validation for compatibility in prior releases #116038
Conversation
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @laozc! |
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @laozc. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
a0b349f
to
ec412c2
Compare
Ping. Would you mind taking a bit of your time reviewing the PR? |
/sig autoscaling |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: laozc The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Previous versions (<1.26) may store the HPA object using V1 schema which adds an extra TargetValue with default value "0" to the store. It fails the HPA validation and prevent any further modifications on the same object unless the TargetValue is set to a positive value. The issue does not impact 1.26 as the default store version is v2. Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
You write that the issue is fixed in 1.26. The change of default store version to v2 happened in 1.27 (40a6d63). I also confirmed this by creating 1.26 and 1.27 clusters. In 1.26 the bug still exists. |
I didn't check it in 1.26. How long before 1.26 phases out? |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Previous versions (<=1.26) may store the HPA object using V1 schema which adds an extra TargetValue with default value "0" to the store. It fails the HPA validation and prevent any further modifications on the same object unless the TargetValue is set to a positive value.
The issue does not impact 1.26 as the default store version is v2.
What type of PR is this?
/kind bug
What this PR does / why we need it:
The patch mainly delivers a fix for HPA compatibility in earlier releases (<1.26) which updating HPA may result in a validation failure.
K8s >= 1.26 is not affected by the issue.
The PR should be cherry-picked to version prior to 1.26.
Which issue(s) this PR fixes:
Fixes #87733
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
NONE