Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kmsv2: improve test coverage #116202

Merged
merged 1 commit into from Mar 3, 2023
Merged

kmsv2: improve test coverage #116202

merged 1 commit into from Mar 3, 2023

Conversation

ritazh
Copy link
Member

@ritazh ritazh commented Mar 2, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

Increase test coverage for kmsv2 changes to above 75%

Which issue(s) this PR fixes:

Partially addressing #114188

Special notes for your reviewer:

k8s.io/kubernetes/staging/src/k8s.io/apiserver/pkg/storage/value/encrypt/envelope/metrics coverage: 79.1% of statements
k8s.io/kubernetes/staging/src/k8s.io/apiserver/pkg/server/options/encryptionconfig coverage: 75.2% of statements

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[KEP] https://github.com/kubernetes/enhancements/tree/master/keps/sig-auth/3299-kms-v2-improvements

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 2, 2023
@ritazh
Copy link
Member Author

ritazh commented Mar 2, 2023

/sig auth
/triage accepted
/priority important-soon
/assign @enj

@k8s-ci-robot k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 2, 2023
@ritazh
Copy link
Member Author

ritazh commented Mar 2, 2023

/test pull-kubernetes-e2e-kind-kms

ritazh
ritazh commented Mar 2, 2023
View reviewed changes
staging/src/k8s.io/kms/internal/plugins/mock/go.mod
@@ -3,7 +3,7 @@ module k8s.io/kms/plugins/mock
go 1.19

require (
k8s.io/klog/v2 v2.90.0
k8s.io/klog/v2 v2.90.1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran go mod tidy to fix e2e job failure:

CGO_ENABLED=0 GOOS=linux GOARCH=${TARGETARCH} GO111MODULE=on go build -a -o mock-kms-plugin plugin.go
go: downloading k8s.io/klog/v2 v2.90.0
go: updates to go.mod needed; to update it:
go mod tidy

@enj
Copy link
Member

enj commented Mar 3, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enj, ritazh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2023
@ritazh
kmsv2: improve test coverage
51db940 
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
aramase
aramase reviewed Mar 3, 2023
View reviewed changes
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 98d7151a0fb16a11c003fe3a5f585443fa9ae545

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

1 similar comment
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@pacoxu
Copy link
Member

pacoxu commented Mar 3, 2023

/retest
for flake #116165

@pacoxu
Copy link
Member

pacoxu commented Mar 3, 2023

/test pull-kubernetes-e2e-gce-100-performance

@ritazh
Copy link
Member Author

ritazh commented Mar 3, 2023

/retest

@k8s-ci-robot k8s-ci-robot merged commit 1658295 into kubernetes:master Mar 3, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Mar 3, 2023
@ritazh ritazh deleted the kmsv2-testcoverage branch March 3, 2023 14:52
@liggitt liggitt mentioned this pull request Mar 16, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aramase aramase aramase left review comments

@enj enj enj requested changes

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@enj enj

@aramase aramase

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Archived in project
SIG Auth: KMS v2
Status: ✅ Done
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ritazh @enj @k8s-ci-robot @k8s-triage-robot @pacoxu @aramase