Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Konnectivity to 0.1.2 #116348

Merged
merged 1 commit into from Apr 11, 2023
Merged

Bump Konnectivity to 0.1.2 #116348

merged 1 commit into from Apr 11, 2023

Conversation

jkh52
Copy link
Contributor

@jkh52 jkh52 commented Mar 7, 2023 •
edited

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fixes memory leaks.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Desired memory leak fix: kubernetes-sigs/apiserver-network-proxy#467

All changes since 0.1.1: kubernetes-sigs/apiserver-network-proxy@v0.1.1...v0.1.2

Manual edits:

vendor/modules.txt
cluster/gce/addons/konnectivity-agent/konnectivity-agent-ds.yaml
cluster/gce/manifests/konnectivity-server.yaml

Commands:

./hack/pin-dependency.sh sigs.k8s.io/apiserver-network-proxy/konnectivity-client v0.1.2
./hack/update-codegen.sh
./hack/update-vendor.sh

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 7, 2023
@jkh52
Copy link
Contributor Author

jkh52 commented Mar 7, 2023

Draft, pending images promotion

@k8s-ci-robot k8s-ci-robot added area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubectl area/provider/gcp Issues or PRs related to gcp provider sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 7, 2023
@jkh52 jkh52 marked this pull request as ready for review March 8, 2023 03:45
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2023
@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Mar 10, 2023
@jkh52
Copy link
Contributor Author

jkh52 commented Mar 10, 2023

/retest

@jkh52
Copy link
Contributor Author

jkh52 commented Mar 13, 2023

Friendly ping (lgtm tag lost only due to rebase).

@tallclair
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 288af336e5a0f1ed26ba6f2268e1f38f7764ef49

@mrunalp mrunalp moved this from Needs Approver to Done in SIG Node PR Triage Mar 14, 2023
@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 14, 2023
@jkh52
Copy link
Contributor Author

jkh52 commented Apr 7, 2023

Friendly ping.

@jkh52
Copy link
Contributor Author

jkh52 commented Apr 7, 2023

/assign @liggitt

@liggitt
Copy link
Member

liggitt commented Apr 7, 2023

/approve
/milestone v1.28

@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Apr 7, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkh52, liggitt, mrunalp, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit 68f8732 into kubernetes:master Apr 11, 2023
1 check passed
This was referenced Apr 13, 2023
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp approved these changes

@soltysh soltysh soltysh approved these changes

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@brianpursley brianpursley Awaiting requested review from brianpursley

@AlexeyPerevalov AlexeyPerevalov Awaiting requested review from AlexeyPerevalov

@alexzielenski alexzielenski Awaiting requested review from alexzielenski

@bowei bowei Awaiting requested review from bowei

@deads2k deads2k Awaiting requested review from deads2k

@marquiz marquiz Awaiting requested review from marquiz

@sttts sttts Awaiting requested review from sttts

@tallclair tallclair Awaiting requested review from tallclair

@wlan0 wlan0 Awaiting requested review from wlan0

Assignees

@sttts sttts

@bowei bowei

@liggitt liggitt

@marquiz marquiz

@wlan0 wlan0

@deads2k deads2k

@tallclair tallclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubectl area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Archived in project
SIG Node PR Triage
Done
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet