-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.24] Bump konnectivity-client to 0.0.37 #117316
[release-1.24] Bump konnectivity-client to 0.0.37 #117316
Conversation
/assign @tallclair |
/triage accepted |
the client change in this PR looks like a no-op, right? is the leak fix in the server component being bumped? |
/approve |
/assign @cheftako based on the other reviews |
@cpanato: GitHub didn't allow me to assign the following users: on, the, other, reviews, based. Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
LGTM label has been added. Git tree hash: 5f826b83867031262eff083bf990d17918ac326b
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jkh52, liggitt, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixes memory leaks (affecting proxy-server and proxy-agent).
Which issue(s) this PR fixes:
The desired fix: kubernetes-sigs/apiserver-network-proxy#467
Special notes for your reviewer:
Master branch took this fix in #116348, but here we use the more backport friendly tag 0.0.37 rather than 0.1.2.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: