-
Notifications
You must be signed in to change notification settings - Fork 39.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Scheduler] Make sure handlers have synced before scheduling #116729
Conversation
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ccc5b03
to
d14c5d1
Compare
Current implementation returns a |
/cc @alculquicondor |
On a second thought, since we never break app.Run(). These handlers will never be garbage collected, so I've decided to use the later option. |
storing sounds good. /assign @denkensk |
kindly ping @aojea |
ping @aojea |
d412b0c
to
a0082b7
Compare
/lgtm |
LGTM label has been added. Git tree hash: 33f44835a03f89bea51ec77b9a4efb2312f369b6
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, aojea, AxeZhan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kindly ping @alculquicondor |
/lgtm |
LGTM label has been added. Git tree hash: a64c783bdf4134448f0c5677a870191dae9615f2
|
/retest |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Make sure handlers have finished syncing before the scheduling cycles start.
Which issue(s) this PR fixes:
Fixes #116717
Special notes for your reviewer:
This may not be a clean approach because it changes the return parameters for
scheduler.New
, and I am looking forward to finding some more clean solutions.Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: