Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.26] Drop development dependencies from test targets #116853

Merged
merged 1 commit into from Mar 22, 2023
Merged

[1.26] Drop development dependencies from test targets #116853

merged 1 commit into from Mar 22, 2023

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Mar 22, 2023 •
edited

/kind cleanup
/kind failing-test

What this PR does / why we need it:

Cherry-pick of #116860

Drops development-time binaries we don't distribute from from test targets, since they tend to cause link issues on arm-32

https://testgrid.k8s.io/sig-release-1.24-blocking#build-1.24
#115738
#116492
#115675

NONE

@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Mar 22, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 22, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2023
@liggitt
Copy link
Member Author

liggitt commented Mar 22, 2023

/test pull-kubernetes-cross
/sig release testing architecture

@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 22, 2023
@liggitt
Copy link
Member Author

liggitt commented Mar 22, 2023

/retest

@liggitt liggitt changed the title [1.26] Drop linux/arm from test targets [1.26] Drop development dependencies from test targets Mar 22, 2023
@liggitt
Copy link
Member Author

liggitt commented Mar 22, 2023

/test pull-kubernetes-cross

@dims
Copy link
Member

dims commented Mar 22, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 645a4a9923be5f9820b7ae8d15c1c276511bd48c

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt liggitt added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Mar 22, 2023
@k8s-ci-robot k8s-ci-robot removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 22, 2023
@liggitt
Copy link
Member Author

liggitt commented Mar 22, 2023

cc @kubernetes/release-managers
this is the same change as #116850 on 1.24, which fixes broken cross-build on linux/arm which is failing building these binaries we don't actually use in the release - https://testgrid.k8s.io/sig-release-1.24-blocking#build-1.24

@jeremyrickard jeremyrickard added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Mar 22, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9043dd8 into kubernetes:release-1.26 Mar 22, 2023
16 checks passed
@liggitt liggitt deleted the arm-1.26 branch March 24, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavalamp lavalamp Awaiting requested review from lavalamp

@SataQiu SataQiu Awaiting requested review from SataQiu

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@liggitt @dims @k8s-ci-robot @jeremyrickard