Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop development dependencies from test targets #116860

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Drop development dependencies from test targets #116860

merged 1 commit into from
Mar 22, 2023

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Mar 22, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Drops development-time binaries we don't distribute in releases from the test targets list

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 22, 2023
This was referenced Mar 22, 2023
Merged
Merged
Merged
@liggitt
Copy link
Member Author

liggitt commented Mar 22, 2023

/sig release testing

@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 22, 2023
@dims
Copy link
Member

dims commented Mar 22, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ac7955f21d9de30e2e7e2fc02f94dba1241484b5

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt liggitt added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Mar 22, 2023
@k8s-ci-robot k8s-ci-robot removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 22, 2023
@liggitt
Copy link
Member Author

liggitt commented Mar 22, 2023

cc @kubernetes/release-managers
this is the same change as #116850 on 1.24, which fixes broken cross-build on linux/arm which is failing building these binaries we don't actually use in the release - https://testgrid.k8s.io/sig-release-1.24-blocking#build-1.24

/milestone v1.27
/hold for discussion with release managers - we can either include this in 1.27 or wait for 1.28 and pick to the release-1.27 branch ... your call

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 22, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Mar 22, 2023
@jeremyrickard
Copy link
Contributor

/hold cancel

I think it makes sense to merge this now and CP back to the other branches ahead of the branch cut. If we run into issues, let's revert this.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 22, 2023
@k8s-ci-robot k8s-ci-robot merged commit d2be69a into kubernetes:master Mar 22, 2023
@liggitt
Copy link
Member Author

liggitt commented Mar 22, 2023

https://testgrid.k8s.io/sig-release-master-blocking#build-master stayed green (and dropped ~3 minutes of the best recent run time)

image

@Rajalakshmi-Girish Rajalakshmi-Girish mentioned this pull request Mar 24, 2023
Merged
@liggitt liggitt deleted the test-binary branch May 9, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavalamp lavalamp Awaiting requested review from lavalamp

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@liggitt @dims @k8s-ci-robot @jeremyrickard