Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.24] Automated cherry pick of #117020: Return error for localhost seccomp type with no localhost #117118

Merged
merged 1 commit into from
Apr 17, 2023
Merged

[1.24] Automated cherry pick of #117020: Return error for localhost seccomp type with no localhost #117118

merged 1 commit into from
Apr 17, 2023

Conversation

cji
Copy link
Member

@cji cji commented Apr 5, 2023 •
edited
Loading

Cherry pick of #117020 on release-1.24.

#117020: Return error for localhost seccomp type with no localhost

For details on the cherry pick process, see the cherry pick requests page.

/kind bug

@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Apr 5, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 5, 2023
@cji cji changed the title Automated cherry pick of #117020: Return error for localhost seccomp type with no localhost [1.24] Automated cherry pick of #117020: Return error for localhost seccomp type with no localhost Apr 5, 2023
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 5, 2023
@cji cji force-pushed the automated-cherry-pick-of-#117020-upstream-release-1.24 branch from 100b658 to 73174f8 Compare April 5, 2023 19:47
@cji
Copy link
Member Author

cji commented Apr 5, 2023

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Apr 5, 2023
@cji
Copy link
Member Author

cji commented Apr 5, 2023

/retest

1 similar comment
@cji
Copy link
Member Author

cji commented Apr 5, 2023

/retest

@bart0sh
Copy link
Contributor

bart0sh commented Apr 6, 2023

/triage accepted
/priority important-soon
/assign @liggitt

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 6, 2023
@liggitt
Copy link
Member

liggitt commented Apr 6, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 6, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c8dd18d65172b68000f5b72edc1a569cf85ac8de

@liggitt
Copy link
Member

liggitt commented Apr 6, 2023

/hold for master PR merge

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 6, 2023
@liggitt
Copy link
Member

liggitt commented Apr 13, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 13, 2023
saschagrunert
saschagrunert approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cji, liggitt, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert saschagrunert added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Apr 17, 2023
@k8s-ci-robot k8s-ci-robot merged commit 2460dd4 into kubernetes:release-1.24 Apr 17, 2023
@SaranBalaji90 SaranBalaji90 mentioned this pull request Jun 15, 2023
Closed
@Priyankasaggu11929 Priyankasaggu11929 mentioned this pull request Jun 20, 2023
Closed
wongma7 pushed a commit to wongma7/kubernetes that referenced this pull request Jul 24, 2023
@cji @wongma7
--EKS-PATCH-- Return error for localhost seccomp type with no localho…
5a94026 
…st profile defined

Description:
* "Returns an error when a Pod or Container's SecurityContext has a localhost seccomp type but an empty
localhostProfile field" (PR description)

Upstream PR, Issue, KEP, etc. links:
* PR: kubernetes#117118
* Commit: 73174f8
* Issue: kubernetes#118690

If this patch is based on an upstream commit, how (if at all) do this patch and the upstream source differ?
* The cherry-pick is from 1.24, so there could be some minor differences.

If this patch's changes have not been added by upstream, why not?
* N/A

Other patches related to this patch:
* None

Changes made to this patch after its initial creation and reasons for these changes:
* None

Kubernetes version this patch can be dropped:
* This patch is not needed in >= 1.24, as it has been added by upstream.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@odinuge odinuge Awaiting requested review from odinuge

@yujuhong yujuhong Awaiting requested review from yujuhong

Assignees

@saschagrunert saschagrunert

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Archived in project
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cji @bart0sh @liggitt @k8s-ci-robot @saschagrunert