Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write the stress test for gRPC, http, and tcp probes #117439

Closed
wants to merge 11 commits into from
Closed

Write the stress test for gRPC, http, and tcp probes #117439

wants to merge 11 commits into from

Conversation

lanycrost
Copy link
Contributor

What type of PR is this?

/kind cleanup
/area tests

@kubernetes/sig-architecture-pr-reviews @kubernetes/sig-node-pr-reviews

What this PR does / why we need it:

This PR adds stress tests for GRPC, HTTP and TCP probes with this logic.

  • Create MANY containers.
  • Each container has a liveness probe with 1s interval.
  • After some time validate that neither of containers has restartCount > 0.

Which issue(s) this PR fixes:

Fixes #115782

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 18, 2023
@k8s-ci-robot
Copy link
Contributor

@lanycrost: The label(s) area/tests cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind cleanup
/area tests

@kubernetes/sig-architecture-pr-reviews @kubernetes/sig-node-pr-reviews

What this PR does / why we need it:

This PR adds stress tests for GRPC, HTTP and TCP probes with this logic.

  • Create MANY containers.
  • Each container has a liveness probe with 1s interval.
  • After some time validate that neither of containers has restartCount > 0.

Which issue(s) this PR fixes:

Fixes #115782

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 18, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @lanycrost. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@lanycrost: Reiterating the mentions to trigger a notification:
@kubernetes/sig-architecture-pr-reviews, @kubernetes/sig-node-pr-reviews

In response to this:

What type of PR is this?

/kind cleanup
/area tests

@kubernetes/sig-architecture-pr-reviews @kubernetes/sig-node-pr-reviews

What this PR does / why we need it:

This PR adds stress tests for GRPC, HTTP and TCP probes with this logic.

  • Create MANY containers.
  • Each container has a liveness probe with 1s interval.
  • After some time validate that neither of containers has restartCount > 0.

Which issue(s) this PR fixes:

Fixes #115782

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 18, 2023
@bart0sh bart0sh added this to Triage in SIG Node PR Triage Apr 18, 2023
@bart0sh
Copy link
Contributor

bart0sh commented Apr 19, 2023

/triage accepted
/priority important-longterm
/assign @SergeyKanzhelev @pacoxu @bart0sh
/ok-to-test
/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Apr 19, 2023
@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 19, 2023
@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 19, 2023
@bart0sh
Copy link
Contributor

bart0sh commented Jan 27, 2024

/retest

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework labels Jan 30, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lanycrost
Once this PR has been reviewed and has the lgtm label, please ask for approval from aojea. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Jan 30, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 30, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 1, 2024
reinka
reinka reviewed Mar 1, 2024
View reviewed changes
test/e2e/framework/framework.go
@@ -56,7 +56,9 @@ import (
const (
// DefaultNamespaceDeletionTimeout is timeout duration for waiting for a namespace deletion.
DefaultNamespaceDeletionTimeout = 5 * time.Minute
defaultServiceAccountName = "default"
// DefaultObservationTimeout is duration where checking kubernetes object status.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might be a little typo in is duration where checking, maybe this should mean something along the lines of
// DefaultObservationTimeout specifies the maximum duration to wait when checking the status of kubernetes objects?

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

SIG Node CI/Test Board automation moved this from PRs - Needs Reviewer to Done Mar 31, 2024
SIG Node PR Triage automation moved this from Needs Reviewer to Done Mar 31, 2024
@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lanycrost
Copy link
Contributor Author

lanycrost commented Apr 1, 2024 •
edited

Are we going to merge this pull request?

@bart0sh @SergeyKanzhelev @pacoxu @aojea

@aperrot42 aperrot42 mentioned this pull request Apr 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@pacoxu pacoxu pacoxu left review comments

@yuzhiquan yuzhiquan yuzhiquan left review comments

@aojea aojea aojea left review comments

@reinka reinka reinka left review comments

@bart0sh bart0sh bart0sh left review comments

@endocrimes endocrimes Awaiting requested review from endocrimes

@odinuge odinuge Awaiting requested review from odinuge

@wzshiming wzshiming Awaiting requested review from wzshiming

Assignees

@bobbypage bobbypage

@pacoxu pacoxu

@aojea aojea

@SergeyKanzhelev SergeyKanzhelev

@bart0sh bart0sh

Labels
area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Status: Done
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write the stress test for gRPC, http, and tcp probes