-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support the "ephemeralcontainers" subresource in edit, get, patch, and replace #117490
base: master
Are you sure you want to change the base?
Support the "ephemeralcontainers" subresource in edit, get, patch, and replace #117490
Conversation
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dlipovetsky The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @verb |
/test pull-kubernetes-e2e-kind |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale I've added this PR to the sig-CLI office hours agenda for this week. |
From @soltysh in today's SIG CLI office hours: This PR needs to consider the KEP that introduced the Also from today's SIG CLI office hours: @ardaguclu mentioned a proposed KEP (kubernetes/enhancements#4293) to provide "custom" profiles to |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Allows
kubectl
users to use commands with theephemeralcontainers
subresource.For example,As of 1.27,kubectl debug
does not allow a user to patch the ephemeral container's security context. An alternative is to usekubectl patch
, e..g.:kubectl debug
allows the user to use "profiles" to set the ephemeral container's security context. Butkubectl patch
is useful for additional customization of ephemeral containers, and that's enabled by this PR.The above example works with this PR, but fails in master.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I'm not sure that the "supported subresources" constraint is necessary. If I can make a case for removing it, I'll file a separate PR.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: