-
Notifications
You must be signed in to change notification settings - Fork 39.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return Skip in InterPodAffinity#PreScore under specific conditions #117794
Conversation
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @utam0k. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
It might be beneficial for @sanposhiho to review the issue since he is the author of this issue. |
/ok-to-test |
/assign |
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, leave for @sanposhiho
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only one nit
pkg/scheduler/framework/plugins/interpodaffinity/scoring_test.go
Outdated
Show resolved
Hide resolved
@utam0k Also, please help to change the release note:
(simplify the description + add the note about metric values) |
189885e
to
a365979
Compare
pkg/scheduler/framework/plugins/interpodaffinity/scoring_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please help other refactor along with that
pkg/scheduler/framework/plugins/interpodaffinity/scoring_test.go
Outdated
Show resolved
Hide resolved
pkg/scheduler/framework/plugins/interpodaffinity/scoring_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please help other refactor along with that
@sanposhiho |
0f521bc
to
6dd83f3
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 440ab3a920299a0a754b6332edbf7d27cae58956
|
/assign @alculquicondor |
This commit updates the InterPodAffinity PreScore to return a Skip status when the following conditions are met: 1. There are no nodes to score. 2. The incoming pod has no inter-pod affinities && the `IgnorePreferredTermsOfExistingPods` option is enabled. Signed-off-by: utam0k <k0ma@utam0k.jp>
6dd83f3
to
c0611b6
Compare
@alculquicondor Thank you for taking the time to review this. Please take another look 🙏 |
/approve |
LGTM label has been added. Git tree hash: 4138423bb702d740de1f1ad8fe3af65695e2f03d
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, sanposhiho, utam0k, Vivekgaddigi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This commit updates the InterPodAffinity PreScore to return a Skip status when the following conditions are met:
IgnorePreferredTermsOfExistingPods
option is enabled.Which issue(s) this PR fixes:
This change is a part of the work for issue #115745
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: