Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed the deprecated azureFile in-tree storage plugin #118236

Merged
merged 1 commit into from May 29, 2023
Merged

removed the deprecated azureFile in-tree storage plugin #118236

merged 1 commit into from May 29, 2023

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented May 24, 2023 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

removed the deprecated azureFile in-tree storage plugin

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

removed the deprecated `azureFile` in-tree storage plugin

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

removed the deprecated `azureFile` in-tree storage plugin

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 24, 2023
@andyzhangx andyzhangx mentioned this pull request May 24, 2023
Closed
@andyzhangx
Copy link
Member Author

/priority important-soon
/sig cloud-provider
/area provider/azure
/triage accepted
/sig storage

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. area/provider/azure Issues or PRs related to azure provider triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 24, 2023
@sftim
Copy link
Contributor

sftim commented May 24, 2023

My suggestion for the changelog:

removed the deprecated `azureFile` in-tree storage plugin

Do we want to mention CSI drivers here?

@bart0sh bart0sh added this to Triage in SIG Node PR Triage May 24, 2023
@dims
Copy link
Member

dims commented May 24, 2023

/assign @xing-yang @msau42
/approve

/meow

@k8s-ci-robot
Copy link
Contributor

@dims: cat image

In response to this:

/assign @xing-yang @msau42
/approve

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2023
@andyzhangx andyzhangx changed the title remove Azure file in-tree storage plugin removed the deprecated azureFile in-tree storage plugin May 25, 2023
@bart0sh bart0sh moved this from Triage to Needs Reviewer in SIG Node PR Triage May 25, 2023
@andyzhangx
Copy link
Member Author

/assign @jsafrane

@jsafrane
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3e742cd8fd8befc49b7bc33bcc9572eccdff9c24

@k8s-ci-robot k8s-ci-robot merged commit a6f641b into kubernetes:master May 29, 2023
22 checks passed
SIG Node PR Triage automation moved this from Needs Reviewer to Done May 29, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 29, 2023
@xing-yang
Copy link
Contributor

xing-yang commented Jun 1, 2023 •
edited

The feature gate for AzureFile CSI Migration was not locked true until 1.27. So we should wait until 1.30 to remove the in-tree plugin. cc @jsafrane @msau42

#114953

@jsafrane
Copy link
Member

jsafrane commented Jun 1, 2023

I'll revert this PR tomorrow. @andyzhangx, we need to wait for one more release.

@jsafrane
Copy link
Member

jsafrane commented Jun 1, 2023

/meow sad

@k8s-ci-robot
Copy link
Contributor

@jsafrane: cat image

In response to this:

/meow sad

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andyzhangx
Copy link
Member Author

/meow sad

@k8s-ci-robot
Copy link
Contributor

@andyzhangx: cat image

In response to this:

/meow sad

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andyzhangx andyzhangx mentioned this pull request Jun 2, 2023
Merged
@andyzhangx
Copy link
Member Author

this is the reverted PR: #118388

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haircommander haircommander Awaiting requested review from haircommander

@msau42 msau42 Awaiting requested review from msau42

Assignees

@xing-yang xing-yang

@jsafrane jsafrane

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@andyzhangx @sftim @dims @k8s-ci-robot @jsafrane @xing-yang @msau42