node: sample-device-plugin: register to kubelet by default and ensure re-registration to kubelet on kubelet restarts #118534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
/sig node |
k8s-ci-robot
added
sig/node
swatisehgal
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
swatisehgal
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
swatisehgal
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
swatisehgal
force-pushed
the
sample-dp-register-by-default
branch
2 times, most recently
from
ec9c8de
to
b6f43aa
Compare
swatisehgal
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/cc @ffromani |
swatisehgal
force-pushed
the
sample-dp-register-by-default
branch
from
b6f43aa
to
9e0ce49
Compare
|
/retest |
k8s-ci-robot
added
do-not-merge/hold
In issue: 115107 we added an environment variable to control the registration of sample device plugin to kubelet. The intent of this patch is to ensure that the default behaviour of the plugin is to register to kubelet (in case no environment variable is specified). In addition to that, we want to ensure that the plugin registers itself not just once. It should re-register itself to kubelet in case of node reboot or kubelet restarts. Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
In case `REGISTER_CONTROL_FILE` is specified, we want to ensure that the registration is triggered by deletion of the control file. This is applicable both when the registration happens for the first time and subsequent ones because of kubelet restarts. Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
If the user specifies the intent to control registration process, we rely on registration triggers (deletion of control file) to prompt registration. This behvaiour is expected to be consistent across kubelet restarts and therefore across the watch calls where we watch for changes to the unix socket so we make this part of Stub object instead of a parameter. Co-authored-by: Francesco Romani <fromani@redhat.com> Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
Setting a reasonable default in case `PLUGIN_SOCK_DIR` environment variable is not specified. Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
Add kubeletSocket file to fsnotify instead of polling and waiting for deletion of device plugin unix socket as a way of detecting kubelet restart. We need to ensure that the device plugin re-registers itself after kubelet restart depending on the configured registration mode (auto-registration or controller registration). Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
Add retry mechanism to handle cases where after kubelet restarts, the device plugin unix socket(s) were created but not ready to serve yet. Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
swatisehgal
force-pushed
the
sample-dp-register-by-default
branch
from
4121cda
to
9a354fc
Compare
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
requested review from
dchen1107,
dims,
klueska and
SergeyKanzhelev
|
LGTM label was removed as the PR had to be rebased. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: d4cbc01fed243e279f7cade8611f421b067d65a4
|
tedyu
reviewed
Oct 19, 2023
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derekwaynecarr, dims, SergeyKanzhelev, swatisehgal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
In #115107 we added an environment variable to control the registration of sample
device plugin to kubelet. The intent of this patch is to ensure that the default
behaviour of the plugin is to register to kubelet (in case no environment
variable is specified).
In addition to that, we want to ensure that the plugin registers itself not just once.
It should re-register itself to kubelet in case of node reboot or kubelet restarts.
Which issue(s) this PR fixes:
Related to:
Special notes for your reviewer:
This PR would require a follow-up to promote the sample device plugin image similar to the work done here.
Does this PR introduce a user-facing change?