Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return deprecation warning for storageOS,PhotonPD,ScaleIO..etc #118563

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Return deprecation warning for storageOS,PhotonPD,ScaleIO..etc #118563

merged 1 commit into from
Jun 8, 2023

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Jun 8, 2023 •
edited

/kind bug

NONE

Additional Note for reviewer:

May be we missed out to add these deprecation warnings in pvspec path while deprecating. This was a learning while addressing comment from @jsafrane ( Thx) #118143 (comment)

@humblec
Return deprecation warning for storageOS,PhotonPD,ScaleIO..etc
fdc49f5 
Thes plugins are deprecated in earlier version of Kubernetes, however
the PVspec was not validated and provided enough warning that, these
are deprecated plugins. This commit add the warning and unit tests
for the same.

Signed-off-by: Humble Chirammal <humble.devassy@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 8, 2023
@humblec
Copy link
Contributor Author

humblec commented Jun 8, 2023

/triage accepted
/priority important-longterm
/sig storage
/assign @jsafrane @msau42 @xing-yang

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Jun 8, 2023
@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 8, 2023
@jsafrane
Copy link
Member

jsafrane commented Jun 8, 2023

/lgtm
from storage POV

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5089a2ea3d81b061983dcc4f8e0d9d0bfa0c19dd

@msau42
Copy link
Member

msau42 commented Jun 8, 2023

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: humblec, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2023
@msau42
Copy link
Member

msau42 commented Jun 8, 2023

/label api-review

@k8s-ci-robot k8s-ci-robot added the api-review Categorizes an issue or PR as actively needing an API review. label Jun 8, 2023
@msau42 msau42 added this to API review completed, 1.28 in API Reviews Jun 8, 2023
@k8s-ci-robot k8s-ci-robot merged commit 4706516 into kubernetes:master Jun 8, 2023
12 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwittrock pwittrock Awaiting requested review from pwittrock

@thockin thockin Awaiting requested review from thockin

Assignees

@xing-yang xing-yang

@jsafrane jsafrane

@msau42 msau42

Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
API Reviews
Status: API review completed, 1.28
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@humblec @jsafrane @k8s-ci-robot @msau42 @xing-yang