Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate CephFS plugin from available in-tree drivers. #118143

Merged
merged 1 commit into from Jun 7, 2023
Merged

deprecate CephFS plugin from available in-tree drivers. #118143

merged 1 commit into from Jun 7, 2023
+36 −0

Conversation

humblec
Copy link
Contributor

@humblec humblec commented May 20, 2023 •
edited

Based on https://groups.google.com/a/kubernetes.io/g/dev/c/g8rwL-qnQhk , the consensus was to start the deprecation in v1.28.

This commit start the deprecation process of CephFS plugin from in-tree drivers.

/kind cleanup

Does this PR introduce a user-facing change?

ACTION REQUIRED:  
CephFS volume plugin ( `kubernetes.io/cephfs`) has been deprecated in this release and will be removed in a subsequent release. Alternative is to use CephFS CSI driver (https://github.com/ceph/ceph-csi/) in your Kubernetes Cluster.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 20, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 20, 2023
@humblec
Copy link
Contributor Author

humblec commented May 20, 2023 •
edited

/priority important-soon
/triage accepted
/sig storage

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 20, 2023
@humblec
Copy link
Contributor Author

humblec commented May 20, 2023

/sig storage

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 20, 2023
@humblec
Copy link
Contributor Author

humblec commented May 22, 2023

/assign @xing-yang

iic, no other place require changes, but please let me know if I missed any path , thanks.

@xing-yang
Copy link
Contributor

Can you please keep "Does this PR introduce a user-facing change?" from the original template?

Please add "ACTION REQUIRED to the release notes".

ACTION REQUIRED:  
CephFS provisioner ( `kubernetes.io/cephfs`) has been deprecated in this release and will be removed  in a subsequent release. Please consider moving to [CephFS CSI driver](https://github.com/ceph/ceph-csi).

@xing-yang
Copy link
Contributor

/assign @msau42 @jsafrane

@k8s-ci-robot k8s-ci-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 22, 2023
@humblec humblec requested a review from xing-yang May 22, 2023 15:09
@msau42
Copy link
Member

msau42 commented May 23, 2023

/kind deprecation

@k8s-ci-robot k8s-ci-robot added the kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. label May 23, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 5, 2023
@humblec humblec requested a review from jsafrane June 5, 2023 14:51
jsafrane
jsafrane reviewed Jun 5, 2023
View reviewed changes
pkg/api/persistentvolume/util.go Outdated Show resolved Hide resolved
pkg/api/pod/warnings.go Outdated Show resolved Hide resolved
pkg/api/persistentvolume/util.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 5, 2023
@humblec humblec requested a review from jsafrane June 5, 2023 16:40
@humblec
deprecate CephFS plugin from available in-tree drivers.
c009667 
https://groups.google.com/a/kubernetes.io/g/dev/c/g8rwL-qnQhk
based on above, the consensus was to start the deprecation in v1.28.

This commit start the deprecation process of CephFS plugin from
in-tree drivers.

Signed-off-by: Humble Chirammal <humble.devassy@gmail.com>
@jsafrane
Copy link
Member

jsafrane commented Jun 6, 2023

/lgtm
from storage POV.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 54699839b075829381ecd05503b5b113ee543828

@humblec
Copy link
Contributor Author

humblec commented Jun 6, 2023

cc @thockin for approval from API side .. Thanks !

@dims
Copy link
Member

dims commented Jun 6, 2023

/assign @thockin @smarterclayton

(Folks since Jordan is away, poking you both, can you please approve this if appropriate!)

@thockin
Copy link
Member

thockin commented Jun 7, 2023

This makes me anxious, but we can always drag it out if we need to, I guess.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: humblec, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit 6b700c3 into kubernetes:master Jun 7, 2023
12 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jun 7, 2023
@humblec humblec mentioned this pull request Jun 8, 2023
Merged
@humblec humblec mentioned this pull request Jul 25, 2023
Merged
@carlory carlory mentioned this pull request Aug 11, 2023
Merged
@carlory carlory mentioned this pull request Jan 7, 2024
Merged
@carlory carlory mentioned this pull request Apr 26, 2024
Merged
@sveinpj sveinpj mentioned this pull request Apr 26, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims dims left review comments

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@thockin thockin Awaiting requested review from thockin

@xing-yang xing-yang Awaiting requested review from xing-yang

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

@smarterclayton smarterclayton

@xing-yang xing-yang

@jsafrane jsafrane

@thockin thockin

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@humblec @xing-yang @msau42 @jsafrane @k8s-ci-robot @dims @thockin @smarterclayton