New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CEL lib: Expose errors on authz decisions instead of raising them from check() #118804
CEL lib: Expose errors on authz decisions instead of raising them from check() #118804
Conversation
…m check(). Co-authored-by: Ben Luddy <bluddy@redhat.com>
/cc @jpbetz I made two significant changes from the original:
|
/assign |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy, jpbetz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jiahuif would you do a review pass? At a glance this LGTM to me, when you're happy with it we can merge. |
/lgtm |
LGTM label has been added. Git tree hash: ba190c791a50feed7bffa54627fb4e98bde77296
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
side note: in the future we might want to export the error type to cel, to avoid errored = err != nil
and error() = err.Error()
CEL Optional types could be appropriate for this sort of thing, too. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Revival of #116491
Which issue(s) this PR fixes:
#116261 (comment)
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/sig api-machinery