Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CEL lib: Expose errors on authz decisions instead of raising them from check() #118804

Merged
merged 1 commit into from Jul 13, 2023

Conversation

benluddy
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Revival of #116491

Which issue(s) this PR fixes:

#116261 (comment)

Special notes for your reviewer:

Does this PR introduce a user-facing change?

CEL authorizer checks no longer raise runtime errors. Calls to "check" will always return a decision object and the authorization error (if any) can be accessed within expressions using the new decision methods "errored" and "error".

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig api-machinery

…m check().

Co-authored-by: Ben Luddy <bluddy@redhat.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver labels Jun 21, 2023
@benluddy
Copy link
Contributor Author

/cc @jpbetz

I made two significant changes from the original:

  • The error message itself is exposed via a second method instead of through reason().
  • The return value of allowed() doesn't vary based on the presence of an error.

@jiahuif
Copy link
Member

jiahuif commented Jun 22, 2023

/assign
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 22, 2023
@jpbetz
Copy link
Contributor

jpbetz commented Jul 13, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, jpbetz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2023
@jpbetz
Copy link
Contributor

jpbetz commented Jul 13, 2023

@jiahuif would you do a review pass? At a glance this LGTM to me, when you're happy with it we can merge.

@cici37
Copy link
Contributor

cici37 commented Jul 13, 2023

/lgtm
Thank you!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ba190c791a50feed7bffa54627fb4e98bde77296

Copy link
Member

@jiahuif jiahuif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

side note: in the future we might want to export the error type to cel, to avoid errored = err != nil and error() = err.Error()

@k8s-ci-robot k8s-ci-robot merged commit 1d846a1 into kubernetes:master Jul 13, 2023
12 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jul 13, 2023
@benluddy
Copy link
Contributor Author

in the future we might want to export the error type to cel, to avoid errored = err != nil and error() = err.Error()

CEL Optional types could be appropriate for this sort of thing, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants