Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node: podresources: getallocatable: move to GA #118973

Merged
merged 1 commit into from Jul 17, 2023
Merged

node: podresources: getallocatable: move to GA #118973

merged 1 commit into from Jul 17, 2023

Conversation

ffromani
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

graduate the GetAllocatable podresources endpoint to GA

Which issue(s) this PR fixes:

enhancement: kubernetes/enhancements#2403

Special notes for your reviewer:

N/A

Does this PR introduce a user-facing change?

The GetAllocatableResources podresources API endpoint is now GA

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/pull/4045

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 29, 2023
@ffromani ffromani mentioned this pull request Jun 29, 2023
Closed
4 tasks
@ffromani
Copy link
Contributor Author

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 29, 2023
@k8s-ci-robot k8s-ci-robot added area/kubelet area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 29, 2023
@ffromani ffromani force-pushed the kubelet-podresources-getallocatable-ga branch from f795ece to c310320 Compare June 29, 2023 12:54
@dims
Copy link
Member

dims commented Jul 1, 2023

/test pull-kubernetes-node-e2e-containerd-serial-ec2
/test pull-kubernetes-node-arm64-e2e-containerd-serial-ec2

@ffromani
Copy link
Contributor Author

ffromani commented Jul 3, 2023

/cc @SergeyKanzhelev @swatisehgal

@swatisehgal
Copy link
Contributor

/cc @SergeyKanzhelev @swatisehgal

Sure, will take a look.

swatisehgal
swatisehgal approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@swatisehgal swatisehgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Straightforward PR. Thanks for all your work on this.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 84a7d86ae6728e15bc083ff2b12c41fd3c704e78

@swatisehgal
Copy link
Contributor

/assign @dims
for feature approval

/assign @mrunalp @SergeyKanzhelev
for pkg/kubelet and test/e2e_node changes respectively

@ffromani ffromani force-pushed the kubelet-podresources-getallocatable-ga branch from c310320 to 01c3a51 Compare July 12, 2023 12:11
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2023
@swatisehgal
Copy link
Contributor

/lgtm

/priority important-soon
(this work is planned for 1.28 release)

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 12, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3eca9a6d54fb3f2aded7a8e9602b6a923327495c

@swatisehgal
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 12, 2023
@klueska
Copy link
Contributor

klueska commented Jul 12, 2023

/lgtm
/approve

@ffromani
Copy link
Contributor Author

/cc @SergeyKanzhelev if you want to have a look to the (very trivial) test changes

@bart0sh bart0sh added this to Triage in SIG Node PR Triage Jul 12, 2023
@ffromani
Copy link
Contributor Author

/assign @dchen1107

for feature approval and for final review

@swatisehgal
Copy link
Contributor

@swatisehgal ping me last please, as my approval will end up covering things that others need to look at as well.

@dims Can you please take a look.

@dims
Copy link
Member

dims commented Jul 17, 2023

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, ffromani, klueska, mrunalp, swatisehgal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2023
@k8s-ci-robot k8s-ci-robot merged commit 92856db into kubernetes:master Jul 17, 2023
14 checks passed
SIG Node CI/Test Board automation moved this from Archive-it to Done Jul 17, 2023
SIG Node PR Triage automation moved this from Triage to Done Jul 17, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jul 17, 2023
@ffromani ffromani mentioned this pull request Jul 17, 2023
Merged
@ffromani ffromani deleted the kubelet-podresources-getallocatable-ga branch August 28, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp approved these changes

@bart0sh bart0sh Awaiting requested review from bart0sh

@bobbypage bobbypage Awaiting requested review from bobbypage

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

@klueska klueska Awaiting requested review from klueska

@dims dims Awaiting requested review from dims

@swatisehgal swatisehgal Awaiting requested review from swatisehgal

Assignees

@dims dims

@mrunalp mrunalp

@klueska klueska

@dchen1107 dchen1107

@SergeyKanzhelev SergeyKanzhelev

@swatisehgal swatisehgal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Status: Done
SIG Node PR Triage
Done
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@ffromani @dims @swatisehgal @k8s-ci-robot @klueska @mrunalp @dchen1107 @SergeyKanzhelev