New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/kubelet: implement drop-in configuration directory for kubelet #119390
Conversation
Hi @sohankunkerkar. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/triage accepted |
39696a4
to
d4e4447
Compare
d4e4447
to
92d590e
Compare
I think we should set the default value to |
yes. Maybe even forever. |
3a74475
to
70230d9
Compare
/lgtm |
LGTM label has been added. Git tree hash: 9f0655af011a68bbab2775d8fb2d0d218ab10619
|
/retest |
70230d9
to
10aa6fb
Compare
/lgtm |
LGTM label has been added. Git tree hash: 570d2e55b1011fc4a0d502226aa6fb5f98f792f7
|
@sohankunkerkar: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This implements a drop-in configuration directory for the kubelet by introducing a "--config-dir" flag. Users can provide individual kubelet config snippets in separate files, formatted similarly to kubelet.conf. The kubelet will process the files in alphanumeric order, appending configurations if subfield(s) doesn't exist, overwriting them if they do, and handling lists by overwriting instead of merging. Co-authored-by: Yu Qi Zhang <jerzhang@redhat.com>
10aa6fb
to
06a81d1
Compare
/lgtm |
LGTM label has been added. Git tree hash: c377fc4be14b67eb39618ccaf26eb76c4c8ffd7e
|
This implements a drop-in configuration directory for the kubelet by introducing a
--config-dir
flag. Users can provide individual kubelet config snippets in separate files, formatted similarly tokubelet.conf
. The kubelet will process the files in alphanumeric order, appending configurations if subfield(s) doesn't exist, overwriting them if they do, and handling lists by overwriting instead of merging.What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: