Fix kubelet panic when allocate resource for pod.

[payall4u]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fix kubelet panic when allocate resource for pod.

Which issue(s) this PR fixes:

Fixes #119560

Does this PR introduce a user-facing change?

None

[k8s-ci-robot]

Hi @payall4u. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gjkim42]

/ok-to-test

[gjkim42]

Fixes #119560

I think it would be better to make a test to reproduce the bug and make sure it is fixed by this patch.

[ffromani]

I think I'm missing something here. Which flows may possible set this to nil?
Once allocatedDevices[resource] is initialized, is never reset to nil explicitely and it's explicitely assigned only to the return value of podDevices.devices(), which can never be nil.

I for myself I like updating allocation once everything completed, but I'm wondering if this approach plays nice with the overall design (see comment at line 834-845). Perhaps we should review that part, but this is a much larger endeavour.

[bart0sh]

/triage accepted
/priority important-soon

@payall4u please provide release note

[bart0sh]

/assign @ffromani @klueska
/cc

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 3b1107227de026e682257c25396fea5cf9165944

[bart0sh]

@payall4u I don't think we still need this code on lines 629-632

	// Needs to allocate additional devices.
	if m.allocatedDevices[resource] == nil {
		m.allocatedDevices[resource] = sets.New[string]()
	}

[payall4u]

@payall4u I don't think we still need this code on lines 629-632

	// Needs to allocate additional devices.
	if m.allocatedDevices[resource] == nil {
		m.allocatedDevices[resource] = sets.New[string]()
	}

Right.

[payall4u]

Sorry, I need you to give it another review. @bart0sh

[payall4u]

ping @bart0sh

[bart0sh]

/lgtm
@payall4u sorry for the review delay, I was on vacation.

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 76076e6e067890f1a34d9d2fc078de520007b351

[k8s-ci-robot]

@payall4u: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[payall4u]

Hi @bart0sh @SergeyKanzhelev

How about fix this in 1.30 and cherry-pick to 1.29 ?

[bart0sh]

How about fix this in 1.30 and cherry-pick to 1.29 ?

sounds good to me

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[pacoxu]

/remove-lifecycle stale
/lgtm
/approve
/assign @mrunalp @SergeyKanzhelev
for approval

[payall4u]

Ping @mrunalp @SergeyKanzhelev @klueska

[klueska]

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: klueska, pacoxu, payall4u

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/kubelet/cm/OWNERS [klueska]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment