Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix kubelet image gc #119652

Merged
merged 5 commits into from Nov 13, 2023
Merged

fix kubelet image gc #119652

merged 5 commits into from Nov 13, 2023

Conversation

lixd
Copy link
Contributor

@lixd lixd commented Jul 28, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #119642

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. labels Jul 28, 2023
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.28 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.28.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Fri Jul 28 04:11:54 UTC 2023.

@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 28, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @lixd!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 28, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @lixd. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 28, 2023
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 28, 2023
@lixd
Copy link
Contributor Author

lixd commented Jul 28, 2023

/cc @ffromani

@ffromani
Copy link
Contributor

/ok-to-test
/priority backlog
/triage accepted

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 28, 2023
@ffromani
Copy link
Contributor

Another option could be to store the timestamp of the last check on a checkpoint file (/var/lib/kubelet/...).
In normal operation this checkpoint would be ignored,because kubelet can keep the necessary state in memory, but on kubelet restart/node reboot this will give us a way to do a precise recovery.
Additionally, if the checkpoint is missing, kubelet can happily keep its current behavior (either the one fixed in this PR or the previous).
I'm not sure the extra complexity is worht the gains, and I'm not approver so I can't really say, but I for myself would explore this way.

@bart0sh bart0sh added this to Triage in SIG Node PR Triage Jul 28, 2023
@lixd
Copy link
Contributor Author

lixd commented Jul 28, 2023

/retest

@lixd
Copy link
Contributor Author

lixd commented Jul 28, 2023

/test pull-kubernetes-node-e2e-containerd

@lixd
Copy link
Contributor Author

lixd commented Jul 29, 2023

/cc @bobbypage @odinuge

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 12, 2023
@lixd
fix kubelet image gc
bad0593 
Signed-off-by: lixd <xueduan.li@gmail.com>
@lixd
fix: add unit test
9533cfe 
Signed-off-by: lixd <xueduan.li@gmail.com>
@lixd
fix data race in test
12c0c08 
Signed-off-by: lixd <xueduan.li@gmail.com>
@lixd
Trigger CI
26a395e 
Signed-off-by: lixd <xueduan.li@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 19, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 19, 2023
@lixd
Copy link
Contributor Author

lixd commented Sep 19, 2023

/retest

@lixd
Copy link
Contributor Author

lixd commented Sep 19, 2023

@haircommander this pr rebase and resolved conflict with other commit,need a re lgtm,thanks

@lixd
Copy link
Contributor Author

lixd commented Sep 19, 2023

/cc @dchen1107

@lixd
fix code style
41584bd 
Signed-off-by: lixd <xueduan.li@gmail.com>
@haircommander
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0d718a6564a2e60fc357f9beb7ff8cea677910cf

@lixd
Copy link
Contributor Author

lixd commented Sep 21, 2023

@dchen1107 hi, need approval,please have a look~

@ricky-rav ricky-rav mentioned this pull request Sep 22, 2023
Closed
@dims
Copy link
Member

dims commented Oct 28, 2023

/milestone v1.29

@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Oct 28, 2023
@hailkomputer
Copy link
Member

Hello, bug triage team lead here. I want to check the status and remind that the the code freeze is starting 01:00 UTC Wednesday 1st November 2023 / 18:00 PDT Tuesday 31st October 2023, as we want to ensure that each PR has a chance to be merged.
Are we still targeting the 1.29 release?

@dims
Copy link
Member

dims commented Nov 13, 2023

/approve

mostly testing related, it looks good to me and has been worked on with input with a lot of reviews and has lgtm(s) as well.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, lixd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit c3114b2 into kubernetes:master Nov 13, 2023
14 checks passed
SIG Node PR Triage automation moved this from Needs Approver to Done Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbypage bobbypage Awaiting requested review from bobbypage

@odinuge odinuge Awaiting requested review from odinuge

@bart0sh bart0sh Awaiting requested review from bart0sh

@ffromani ffromani Awaiting requested review from ffromani

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@haircommander haircommander Awaiting requested review from haircommander

@mrunalp mrunalp Awaiting requested review from mrunalp

Assignees

@mrunalp mrunalp

@derekwaynecarr derekwaynecarr

@dchen1107 dchen1107

@haircommander haircommander

@bart0sh bart0sh

@ffromani ffromani

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
[sig-release] Bug Triage
Archived in project
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

[kubelet-image-gc] minimum-image-ttl-duration not work,when kubelet restart.
10 participants
@lixd @k8s-ci-robot @ffromani @bart0sh @haircommander @dims @hailkomputer @mrunalp @derekwaynecarr @dchen1107