Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #118879: expose apiregistration.k8s.io into OpenAPIV3 #119841

Merged
merged 3 commits into from Sep 7, 2023
Merged

Automated cherry pick of #118879: expose apiregistration.k8s.io into OpenAPIV3 #119841

merged 3 commits into from Sep 7, 2023

Conversation

atiratree
Copy link
Member

@atiratree atiratree commented Aug 8, 2023 •
edited by liggitt

Cherry pick of #118879 on release-1.27.

#118879: expose apiregistration.k8s.io into OpenAPIV3

For details on the cherry pick process, see the cherry pick requests page.

Fixes a regression exposed in 1.27 by kubectl switching to openapi v3 by making apiregistration.k8s.io discoverable in openapi/v3

@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Aug 8, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 8, 2023
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 8, 2023
@atiratree
Copy link
Member Author

/kind bug
/kind regression
/sig api-machinery
/assign @Jefftree
/assign @deads2k

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 8, 2023
@k8s-ci-robot k8s-ci-robot added kind/regression Categorizes issue or PR as related to a regression from a prior release. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Aug 8, 2023
@atiratree atiratree mentioned this pull request Aug 8, 2023
Merged
@atiratree
Copy link
Member Author

Not sure if we should backport this further back, but we should at least do 1.27, since the OpenAPIV3 feature has been graduated to stable.

@atiratree
Copy link
Member Author

cc @alexzielenski

@atiratree
Copy link
Member Author

/test pull-kubernetes-node-e2e-containerd

@jiahuif
Copy link
Member

jiahuif commented Aug 10, 2023

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 10, 2023
@deads2k
Copy link
Contributor

deads2k commented Sep 7, 2023

clean backport

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4aba16e7e3b42a4300a3526286cf0eb6d61db802

@atiratree
Copy link
Member Author

atiratree commented Sep 7, 2023 •
edited

still needs a tag from 1.27 approvers

/cc kubernetes/api-approvers

@k8s-ci-robot
Copy link
Contributor

@atiratree: GitHub didn't allow me to request PR reviews from the following users: kubernetes/api-reviewers.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

still needs a tag from 1.27 approvers

/cc @kubernetes/api-reviewers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@atiratree: GitHub didn't allow me to request PR reviews from the following users: kubernetes/api-approvers.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc kubernetes/api-approvers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@atiratree
Copy link
Member Author

/cc @liggitt @thockin @smarterclayton @lavalamp

@liggitt
Copy link
Member

liggitt commented Sep 7, 2023

/approve

based on @deads2k's review

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atiratree, deads2k, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2023
@atiratree
Copy link
Member Author

/priority important-soon
/cc kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested a review from a team September 7, 2023 17:36
@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 7, 2023
Verolop
Verolop reviewed Sep 7, 2023
View reviewed changes
Copy link

@Verolop Verolop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Verolop Verolop added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 7, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Sep 7, 2023
@Verolop
Copy link

Verolop commented Sep 7, 2023

/test pull-kubernetes-unit

@k8s-ci-robot k8s-ci-robot merged commit 0dff9a9 into kubernetes:release-1.27 Sep 7, 2023
14 checks passed
@liggitt liggitt added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Verolop Verolop Verolop left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@deads2k deads2k Awaiting requested review from deads2k

@lavalamp lavalamp Awaiting requested review from lavalamp

@liggitt liggitt Awaiting requested review from liggitt

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@thockin thockin Awaiting requested review from thockin

Assignees

@Verolop Verolop

@Jefftree Jefftree

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@atiratree @jiahuif @deads2k @k8s-ci-robot @liggitt @Verolop @Jefftree @alexzielenski