Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kmsv2: add metric for DEK cache filled #119878

Merged
merged 1 commit into from Aug 19, 2023
Merged

kmsv2: add metric for DEK cache filled #119878

merged 1 commit into from Aug 19, 2023

Conversation

ritazh
Copy link
Member

@ritazh ritazh commented Aug 10, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds apiserver_envelope_encryption_dek_cache_filled metric for current size of DEK cache

Which issue(s) this PR fixes:

Fixes #115275

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Added apiserver_envelope_encryption_dek_cache_filled to measure number of records in data encryption key(DEK) cache.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP] https://github.com/kubernetes/enhancements/tree/master/keps/sig-auth/3299-kms-v2-improvements

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 10, 2023
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.28 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.28.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Aug 9 22:34:30 UTC 2023.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 10, 2023
@ritazh
Copy link
Member Author

ritazh commented Aug 10, 2023

/sig auth
/triage accepted
/assign @enj
/unassign liggitt smarterclayton

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Aug 10, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Aug 10, 2023
@ritazh
Copy link
Member Author

ritazh commented Aug 10, 2023

/retest

enj
enj suggested changes Aug 10, 2023
View reviewed changes
staging/src/k8s.io/apiserver/pkg/storage/value/encrypt/envelope/kmsv2/envelope.go Outdated Show resolved Hide resolved
staging/src/k8s.io/apiserver/pkg/storage/value/encrypt/envelope/kmsv2/cache.go Outdated Show resolved Hide resolved
staging/src/k8s.io/apiserver/pkg/storage/value/encrypt/envelope/metrics/metrics.go Outdated Show resolved Hide resolved
staging/src/k8s.io/apiserver/pkg/storage/value/encrypt/envelope/metrics/metrics.go Outdated Show resolved Hide resolved
staging/src/k8s.io/apiserver/pkg/storage/value/encrypt/envelope/metrics/metrics.go Outdated Show resolved Hide resolved
staging/src/k8s.io/apiserver/pkg/storage/value/encrypt/envelope/kmsv2/envelope_test.go Outdated Show resolved Hide resolved
staging/src/k8s.io/apiserver/pkg/storage/value/encrypt/envelope/kmsv2/envelope_test.go Outdated Show resolved Hide resolved
staging/src/k8s.io/apiserver/pkg/storage/value/encrypt/envelope/kmsv2/envelope_test.go Outdated Show resolved Hide resolved
staging/src/k8s.io/apiserver/pkg/storage/value/encrypt/envelope/kmsv2/envelope_test.go Outdated Show resolved Hide resolved
staging/src/k8s.io/apiserver/pkg/storage/value/encrypt/envelope/kmsv2/envelope_test.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 16, 2023
enj
enj suggested changes Aug 18, 2023
View reviewed changes
staging/src/k8s.io/apiserver/pkg/storage/value/encrypt/envelope/kmsv2/envelope_test.go Outdated Show resolved Hide resolved
staging/src/k8s.io/apiserver/pkg/storage/value/encrypt/envelope/kmsv2/envelope_test.go Outdated Show resolved Hide resolved
staging/src/k8s.io/apiserver/pkg/storage/value/encrypt/envelope/kmsv2/envelope_test.go Show resolved Hide resolved
staging/src/k8s.io/apiserver/pkg/storage/value/encrypt/envelope/kmsv2/envelope_test.go Outdated Show resolved Hide resolved
staging/src/k8s.io/apiserver/pkg/storage/value/encrypt/envelope/kmsv2/envelope_test.go Outdated Show resolved Hide resolved
staging/src/k8s.io/apiserver/pkg/storage/value/encrypt/envelope/kmsv2/envelope_test.go Outdated Show resolved Hide resolved
staging/src/k8s.io/apiserver/pkg/storage/value/encrypt/envelope/kmsv2/envelope_test.go Outdated Show resolved Hide resolved
staging/src/k8s.io/apiserver/pkg/storage/value/encrypt/envelope/kmsv2/envelope_test.go Outdated Show resolved Hide resolved
@ritazh
Copy link
Member Author

ritazh commented Aug 18, 2023

@enj I have addressed all your comments, PTAL. Thanks!

@ritazh
kmsv2: add metric for DEK cache filled
3cbecf2 
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
@enj
Copy link
Member

enj commented Aug 18, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 03cd1f48502220bbbc526e458764eb683eef7d74

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enj, ritazh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2023
@ritazh
Copy link
Member Author

ritazh commented Aug 18, 2023

/retest

@k8s-ci-robot
Copy link
Contributor

@ritazh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-gce 3cbecf2 link unknown /test pull-kubernetes-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ritazh
Copy link
Member Author

ritazh commented Aug 19, 2023

/retest

@k8s-ci-robot k8s-ci-robot merged commit 16310c9 into kubernetes:master Aug 19, 2023
10 of 13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Aug 19, 2023
@ritazh ritazh deleted the kmsv2-metrics-dekcachesize branch August 21, 2023 04:05
@sreeram-venkitesh sreeram-venkitesh mentioned this pull request Nov 1, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enj enj enj requested changes

@liggitt liggitt Awaiting requested review from liggitt

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@enj enj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Archived in project
SIG Auth: KMS v2
Status: ✅ Done
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

kmsv2: add metric for current size of DEK seed cache
3 participants
@ritazh @k8s-ci-robot @enj