-
Notifications
You must be signed in to change notification settings - Fork 38.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.28] Automated cherry pick of #119027: prep for go1.21: use -e in go list #120037
[1.28] Automated cherry pick of #119027: prep for go1.21: use -e in go list #120037
Conversation
For some reason, in go1.21, go list does not allow importing main packages anymore, even if it is for the sake of tracking dependencies (which is a valid use case). A suggestion to work around this is to use -e flag to permit processing of erroneous packages. However, this doesn't seem prudent. Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind cleanup |
/lgtm |
LGTM label has been added. Git tree hash: c2f996bb70c9eb30a32d29df8f2438fb65935b65
|
@liggitt @MadhavJivrajani Is this something that we want to merge at this point or when migrating to Go 1.21? |
we should merge these now, the only things we're backporting are things that are low risk and reasonable for the release branch even if we weren't bumping go versions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For RelEng:
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, MadhavJivrajani, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@MadhavJivrajani: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
Cherry pick of #119027 on release-1.28.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
For some reason, in go1.21, go list does not allow importing main packages anymore, even if it is for the sake of tracking dependencies (which is a valid use case).
A suggestion to work around this is to use -e flag to permit processing of erroneous packages. However, this doesn't seem prudent.
Which issue(s) this PR fixes:
Ref #118996 (comment)
Ref: golang/go#59186
Special notes for your reviewer:
I'm not sure if we should be doing
-e
since that allows processing of ALL erroneous packages.Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: