Add namespace to NotFound error for kubectl logs command #120111

newtondev · 2023-08-22T20:08:53Z

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Adds the namespace when using 'kubectl logs <pod-name>' and the pod is not found. Previously the message returned would be 'Error from server (NotFound): pods "my-pod-name" not found'. This has been updated to reflect the namespace in the message as follows: 'Error from server (NotFound): pods "my-pod-name" not found in namespace "default"'

k8s-ci-robot · 2023-08-22T20:09:01Z

Welcome @newtondev!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2023-08-22T20:09:02Z

Hi @newtondev. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kannon92 · 2023-08-22T20:28:40Z

/ok-to-test

kannon92

Thanks for adding this!

I'm not a reviewer of this area but I think it would be nice to see some tests with this change.

newtondev · 2023-08-23T20:17:27Z

Thanks @kannon92 . I added a test for this change.

newtondev · 2023-08-24T07:02:31Z

/retest

soltysh · 2023-08-31T10:16:28Z

/label tide/merge-method-squash

soltysh · 2023-08-31T10:29:45Z

/triage accepted
/priority backlog

soltysh

/lgtm
/approve

/hold
to get the linter fixes

k8s-ci-robot · 2023-08-31T10:30:17Z

LGTM label has been added.

Git tree hash: 016c959a9dc56248b31afc60a27e6285955c135f

k8s-ci-robot · 2023-08-31T10:30:30Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: newtondev, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~staging/src/k8s.io/kubectl/OWNERS~~ [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Expurple · 2023-09-11T08:14:28Z

@newtondev, thank you for this PR. Can you please add the one-character fix for the linter so that it's finally merged? I'd do that myself, but I can't add commits to your PR

Signed-off-by: Craig Newton <newtondev@gmail.com>

newtondev · 2023-09-11T21:09:42Z

/retest-required

Expurple · 2023-09-22T09:10:36Z

@soltysh @brianpursley, sorry for nagging, but can we do this already? I'm glad to help, but I don't have permissions to do reviews for you

ardaguclu · 2023-11-24T08:07:11Z

staging/src/k8s.io/kubectl/pkg/cmd/logs/logs.go

@@ -276,6 +277,9 @@ func (o *LogsOptions) Complete(f cmdutil.Factory, cmd *cobra.Command, args []str
 		}
 		infos, err := builder.Do().Infos()
 		if err != nil {
+			if apierrors.IsNotFound(err) {
+				err = fmt.Errorf("error from server (NotFound): %w in namespace %q", err, o.Namespace)


Suggested change

err = fmt.Errorf("error from server (NotFound): %w in namespace %q", err, o.Namespace)

err = fmt.Errorf("error from server (NotFound): %v in namespace %s", err, o.Namespace)

seems better but output is equivalent anyway.

ardaguclu · 2023-11-24T08:08:01Z

/lgtm

k8s-ci-robot · 2023-11-24T08:08:10Z

LGTM label has been added.

Git tree hash: fb001907d247999a9ad553488a9a3b5d0cb101c1

k8s-triage-robot · 2024-02-22T08:58:31Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

pacoxu · 2024-03-01T05:09:47Z

/hold
to get the linter fixes

/test pull-kubernetes-verify-lint

pacoxu · 2024-03-01T06:00:40Z

/unhold

…120111) Signed-off-by: Craig Newton <newtondev@gmail.com>

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 22, 2023

k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubectl labels Aug 22, 2023

k8s-ci-robot requested review from brianpursley and soltysh August 22, 2023 20:12

k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 22, 2023

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 22, 2023

kannon92 reviewed Aug 22, 2023

View reviewed changes

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 23, 2023

k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 31, 2023

soltysh approved these changes Aug 31, 2023

View reviewed changes

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 31, 2023

k8s-ci-robot assigned soltysh Aug 31, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 31, 2023

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2023

Add namespace to NotFound error for kubectl logs command

0079274

Signed-off-by: Craig Newton <newtondev@gmail.com>

newtondev force-pushed the kubectl-mention-namespace-for-resources-not-found branch from c73aa4a to 0079274 Compare September 11, 2023 18:31

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2023

k8s-ci-robot requested a review from soltysh September 11, 2023 18:31

ardaguclu reviewed Nov 24, 2023

View reviewed changes

k8s-ci-robot assigned ardaguclu Nov 24, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 24, 2023

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 22, 2024

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2024

k8s-ci-robot merged commit 20b2831 into kubernetes:master Mar 1, 2024
15 checks passed

k8s-ci-robot added this to the v1.30 milestone Mar 1, 2024

Jeffwan pushed a commit to Jeffwan/kubernetes that referenced this pull request Mar 6, 2024

Add namespace to NotFound error for kubectl logs command (kubernetes#…

9493933

…120111) Signed-off-by: Craig Newton <newtondev@gmail.com>

dinhxuanvu pushed a commit to dinhxuanvu/kubernetes that referenced this pull request Mar 28, 2024

Add namespace to NotFound error for kubectl logs command (kubernetes#…

36b7f01

…120111) Signed-off-by: Craig Newton <newtondev@gmail.com>

satyampsoni mentioned this pull request Apr 5, 2024

Update release notes draft to version v1.30.0-rc.0 kubernetes/sig-release#2468

Merged

ah8ad3 pushed a commit to ah8ad3/kubernetes that referenced this pull request Apr 6, 2024

Add namespace to NotFound error for kubectl logs command (kubernetes#…

76e55d4

…120111) Signed-off-by: Craig Newton <newtondev@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add namespace to NotFound error for kubectl logs command #120111

Add namespace to NotFound error for kubectl logs command #120111

newtondev commented Aug 22, 2023

k8s-ci-robot commented Aug 22, 2023

k8s-ci-robot commented Aug 22, 2023

kannon92 commented Aug 22, 2023

kannon92 left a comment

newtondev commented Aug 23, 2023

newtondev commented Aug 24, 2023

soltysh commented Aug 31, 2023

soltysh commented Aug 31, 2023

soltysh left a comment

k8s-ci-robot commented Aug 31, 2023

k8s-ci-robot commented Aug 31, 2023

Expurple commented Sep 11, 2023

newtondev commented Sep 11, 2023

Expurple commented Sep 22, 2023

ardaguclu Nov 24, 2023

ardaguclu commented Nov 24, 2023

k8s-ci-robot commented Nov 24, 2023

k8s-triage-robot commented Feb 22, 2024

pacoxu commented Mar 1, 2024

pacoxu commented Mar 1, 2024

	err = fmt.Errorf("error from server (NotFound): %w in namespace %q", err, o.Namespace)
	err = fmt.Errorf("error from server (NotFound): %v in namespace %s", err, o.Namespace)

Add namespace to NotFound error for kubectl logs command #120111

Add namespace to NotFound error for kubectl logs command #120111

Conversation

newtondev commented Aug 22, 2023

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

k8s-ci-robot commented Aug 22, 2023

k8s-ci-robot commented Aug 22, 2023

kannon92 commented Aug 22, 2023

kannon92 left a comment

Choose a reason for hiding this comment

newtondev commented Aug 23, 2023

newtondev commented Aug 24, 2023

soltysh commented Aug 31, 2023

soltysh commented Aug 31, 2023

soltysh left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Aug 31, 2023

k8s-ci-robot commented Aug 31, 2023

Expurple commented Sep 11, 2023

newtondev commented Sep 11, 2023

Expurple commented Sep 22, 2023

ardaguclu Nov 24, 2023

Choose a reason for hiding this comment

ardaguclu commented Nov 24, 2023

k8s-ci-robot commented Nov 24, 2023

k8s-triage-robot commented Feb 22, 2024

pacoxu commented Mar 1, 2024

pacoxu commented Mar 1, 2024