-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
illumos does not have SO_REUSEPORT. #120498
Conversation
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Welcome @jperkin! |
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @jperkin. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jperkin The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is not a known supported platform for the control plane. |
We should not make changes to enable platforms that we do not support or test against. /hold |
please see https://github.com/kubernetes/sig-release/blob/master/release-engineering/platforms/guide.md needs discussion with sig-testing / sig-release etc. |
Do I see this correctly that this is because grafana embeds a own copy of the kubernetes API server, thus the whole API server is technically a library now? |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Grafana 10.1.0 fails to build on illumos platforms, where previously it built fine. This is due to:
The illumos platform does not have
SO_REUSEPORT
for userland applications.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I've tested this patch successfully fixes the build on illumos, using a forked version of apiserver here: https://github.com/jperkin/apiserver
I can successfully launch
grafana server
after installing the fixed build.Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: