Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature gate UnauthenticatedHTTP2DOSMitigation #8665

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

timuthy
Copy link
Member

@timuthy timuthy commented Oct 18, 2023

How to categorize this PR?

/area open-source
/kind enhancement

What this PR does / why we need it:
The feature gate was added retrospectively to versions 1.25, 1.26, 1.27 and 1.28, see kubernetes/kubernetes#121224.

Special notes for your reviewer:
Thanks @vpnachev.

Release note:

Kubernetes feature gate `UnauthenticatedHTTP2DOSMitigation` is considered valid for versions >= `1.25`.

The feature gate was added retrospectively to versions `1.25`, `1.26`, `1.27`
and `1.28`, see kubernetes/kubernetes#121224.
@gardener-prow gardener-prow bot added area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Oct 18, 2023
@gardener-prow gardener-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 18, 2023
@timuthy
Copy link
Member Author

timuthy commented Oct 18, 2023

/cherry-pick release-v1.82

@gardener-ci-robot
Copy link
Contributor

@timuthy: once the present PR merges, I will cherry-pick it on top of release-v1.82 in a new PR and assign it to you.

In response to this:

/cherry-pick release-v1.82

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@timuthy
Copy link
Member Author

timuthy commented Oct 18, 2023

/cherry-pick release-v1.81

@gardener-ci-robot
Copy link
Contributor

@timuthy: once the present PR merges, I will cherry-pick it on top of release-v1.81 in a new PR and assign it to you.

In response to this:

/cherry-pick release-v1.81

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@timuthy
Copy link
Member Author

timuthy commented Oct 18, 2023

/cherry-pick release-v1.80

@gardener-ci-robot
Copy link
Contributor

@timuthy: once the present PR merges, I will cherry-pick it on top of release-v1.80 in a new PR and assign it to you.

In response to this:

/cherry-pick release-v1.80

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2023
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Oct 18, 2023

LGTM label has been added.

Git tree hash: e9bb3a8d004c4da8eb34058c7b203b2d11d18aaf

@vpnachev
Copy link
Member

/retest-required

1 similar comment
@vpnachev
Copy link
Member

/retest-required

@oliver-goetz
Copy link
Member

/approve

/retest

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Oct 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oliver-goetz, vpnachev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2023
@shafeeqes
Copy link
Contributor

/test pull-gardener-e2e-kind

@gardener-prow gardener-prow bot merged commit 743cc3e into gardener:master Oct 19, 2023
16 checks passed
@gardener-ci-robot
Copy link
Contributor

@timuthy: new pull request created: #8670

In response to this:

/cherry-pick release-v1.82

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gardener-ci-robot
Copy link
Contributor

@timuthy: new pull request created: #8671

In response to this:

/cherry-pick release-v1.81

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@timuthy timuthy deleted the enhancement.k8s-http2-dos branch October 19, 2023 07:35
@gardener-ci-robot
Copy link
Contributor

@timuthy: new pull request created: #8672

In response to this:

/cherry-pick release-v1.80

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants