Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote KEP-2681 to beta in 1.29 #121477

Merged
merged 1 commit into from Nov 1, 2023
Merged

Conversation

wzshiming
Copy link
Member

@wzshiming wzshiming commented Oct 24, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Test fix by #121429

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Promote PodHostIPs condition to beta.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/2681
- [Usage]: <link>
- [Other doc]:

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 24, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Oct 24, 2023
@k8s-ci-robot k8s-ci-robot added area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 24, 2023
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 24, 2023
@wzshiming
Copy link
Member Author

/cc @aojea @thockin

@wzshiming wzshiming marked this pull request as ready for review October 24, 2023 12:43
@wzshiming
Copy link
Member Author

wzshiming commented Oct 24, 2023

https://kubernetes.slack.com/archives/C0BP8PW9G/p1698148744408089?thread_ts=1698045918.027889&cid=C0BP8PW9G

@aojea

Do I add tests to test/e2e/network/dual_stack.go in this PR or after this PR landed?

#121479

@bart0sh bart0sh added this to WIP in SIG Node PR Triage Oct 25, 2023
@wzshiming wzshiming changed the title [WIP] Promote KEP-2681 to beta in 1.29 Promote KEP-2681 to beta in 1.29 Oct 26, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 26, 2023
@dims
Copy link
Member

dims commented Oct 27, 2023

/milestone v1.29

Do we want to do this @thockin @aojea ? is it ready ?

@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Oct 27, 2023
@wzshiming wzshiming mentioned this pull request Oct 29, 2023
@hailkomputer
Copy link
Member

Hello, bug triage team lead here. I want to check the status and remind that the the code freeze is starting 01:00 UTC Wednesday 1st November 2023 / 18:00 PDT Tuesday 31st October 2023, as we want to ensure that each PR has a chance to be merged.
Are we still targeting the 1.29 release?

@dims dims added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed sig/node Categorizes an issue or PR as relevant to SIG Node. labels Oct 30, 2023
@pacoxu
Copy link
Member

pacoxu commented Oct 30, 2023

/priority important-soon

#121429 changed the case to run serialized as the node e2e tried to restart kuebelet. And it will skip if the FG is not enabled.(The current node e2e doesn't support it well, so the current workaround is just to check the default one. THere is a WIP PR #120139 on this)

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 30, 2023
@wzshiming
Copy link
Member Author

Test has been updated in #121429, #121479 and this PR is ready to be merge.

@wzshiming wzshiming moved this from WIP to Needs Approver in SIG Node PR Triage Oct 30, 2023
@aojea
Copy link
Member

aojea commented Oct 30, 2023

/test pull-kubernetes-cos-cgroupv1-containerd-node-e2e-features
/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e-features
/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e-serial

@pacoxu
Copy link
Member

pacoxu commented Oct 31, 2023

/test pull-kubernetes-e2e-kind-alpha-beta-features
/test pull-kubernetes-e2e-kind-alpha-features
/test pull-kubernetes-e2e-kind-beta-features

@thockin
Copy link
Member

thockin commented Oct 31, 2023

I have not had time to re-review this, and as long as tests are failing it's stuck.

@aojea
Copy link
Member

aojea commented Oct 31, 2023

I have not had time to re-review this, and as long as tests are failing it's stuck.

@thockin tests should be good now, this is good to go

@thockin
Copy link
Member

thockin commented Oct 31, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7e50bfbb1bf7b9e6dbcece7bc759db16f2cd290d

@thockin
Copy link
Member

thockin commented Oct 31, 2023

/retest
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thockin, wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2023
@k8s-ci-robot
Copy link
Contributor

@wzshiming: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-kind-beta-features 12a972c link false /test pull-kubernetes-e2e-kind-beta-features
pull-kubernetes-e2e-kind-alpha-beta-features 12a972c link false /test pull-kubernetes-e2e-kind-alpha-beta-features
pull-kubernetes-e2e-kind-alpha-features 12a972c link false /test pull-kubernetes-e2e-kind-alpha-features

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit 9b10019 into kubernetes:master Nov 1, 2023
18 of 21 checks passed
SIG Node PR Triage automation moved this from Needs Approver to Done Nov 1, 2023
@wzshiming wzshiming deleted the kep-2681 branch November 1, 2023 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

7 participants