Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/v1: remove note about hostAliases not working with hostNetwork #122422

Merged
merged 1 commit into from Mar 5, 2024
Merged

core/v1: remove note about hostAliases not working with hostNetwork #122422

merged 1 commit into from Mar 5, 2024

Conversation

neolit123
Copy link
Member

@neolit123 neolit123 commented Dec 20, 2023 •
edited

What type of PR is this?

/kind cleanup documentation

What this PR does / why we need it:

Support for this was added in 1.8 by PR #50646.
Local tests confirm that the feature indeed works. E2e tests seem to be missing.

Which issue(s) this PR fixes:

fixes #122420

Special notes for your reviewer:

a working test was added here:

Does this PR introduce a user-facing change?

PodSpec API: remove note that hostAliases are not supported on hostNetwork Pods. The feature has been supported since v1.8.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@neolit123
core/v1: remove note about hostAliases not working with hostNetwork
47ee56a 
Support for this was added in 1.8 by PR 50646.
Local tests confirm that the feature indeed works.
E2e tests seem to be missing.
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/code-generation kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 20, 2023
@neolit123 neolit123 changed the title WIP: core/v1: remove note about hostAliases not working with hostNetwork core/v1: remove note about hostAliases not working with hostNetwork Dec 20, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 20, 2023
@neolit123
Copy link
Member Author

neolit123 commented Dec 20, 2023 •
edited

some files in staging were not updated, no idea why:

$ grep "HostAliases is an optional" * -rl 
src/k8s.io/kubectl/testdata/openapi/v3/api/v1.json
src/k8s.io/kubectl/testdata/openapi/v3/apis/apps/v1.json
src/k8s.io/kubectl/testdata/openapi/swagger.json
src/k8s.io/kubectl/pkg/explain/v2/templates/batch.k8s.io_v1.json
src/k8s.io/cli-runtime/artifacts/openapi/swagger-with-shared-parameters.json
src/k8s.io/cli-runtime/artifacts/openapi/swagger.json
src/k8s.io/apimachinery/pkg/util/managedfields/internal/testdata/swagger.json
src/k8s.io/client-go/openapi/openapitest/testdata/api__v1_openapi.json
src/k8s.io/client-go/openapi/openapitest/testdata/apis__batch__v1_openapi.json
src/k8s.io/client-go/openapi/openapitest/testdata/apis__apps__v1_openapi.json
src/k8s.io/client-go/discovery/testdata/apis/batch/v1beta1.json
src/k8s.io/client-go/discovery/testdata/apis/batch/v1.json

maybe these files were manually copied as testdata.

@aojea
Copy link
Member

aojea commented Dec 20, 2023

some files in staging were not updated, no idea why:

$ grep "HostAliases is an optional" * -rl 
src/k8s.io/kubectl/testdata/openapi/v3/api/v1.json
src/k8s.io/kubectl/testdata/openapi/v3/apis/apps/v1.json
src/k8s.io/kubectl/testdata/openapi/swagger.json
src/k8s.io/kubectl/pkg/explain/v2/templates/batch.k8s.io_v1.json
src/k8s.io/cli-runtime/artifacts/openapi/swagger-with-shared-parameters.json
src/k8s.io/cli-runtime/artifacts/openapi/swagger.json
src/k8s.io/apimachinery/pkg/util/managedfields/internal/testdata/swagger.json
src/k8s.io/client-go/openapi/openapitest/testdata/api__v1_openapi.json
src/k8s.io/client-go/openapi/openapitest/testdata/apis__batch__v1_openapi.json
src/k8s.io/client-go/openapi/openapitest/testdata/apis__apps__v1_openapi.json
src/k8s.io/client-go/discovery/testdata/apis/batch/v1beta1.json
src/k8s.io/client-go/discovery/testdata/apis/batch/v1.json

maybe these files were manually copied as testdata.

/lgtm
/approve

/assign @thockin

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cafa3b4ba036696659a03a5b84ff17c2902e8664

@neolit123 neolit123 mentioned this pull request Dec 20, 2023
Closed
@seans3
Copy link
Contributor

seans3 commented Dec 21, 2023

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 21, 2023
@dims
Copy link
Member

dims commented Jan 4, 2024

/approve
/lgtm

@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@neolit123
Copy link
Member Author

/assign @msau42 @liggitt
PTAL, when possible.

@pacoxu
Copy link
Member

pacoxu commented Feb 27, 2024 •
edited

ACK for approval @thockin @liggitt

/lgtm
/approve

@liggitt liggitt removed their assignment Feb 27, 2024
@liggitt
Copy link
Member

liggitt commented Feb 27, 2024

seems reasonable, but will defer to @thockin's ack

thockin
thockin reviewed Mar 4, 2024
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, dims, neolit123, pacoxu, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2024
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

1 similar comment
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot
Copy link
Contributor

@neolit123: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-verify 47ee56a link unknown /test pull-kubernetes-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@BenTheElder
Copy link
Member

/retest
kubernetes/test-infra#32157

@k8s-ci-robot k8s-ci-robot merged commit 1c789a9 into kubernetes:master Mar 5, 2024
13 of 14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@pwittrock pwittrock Awaiting requested review from pwittrock

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@dims dims

@pacoxu pacoxu

@thockin thockin

@aojea aojea

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
API Reviews
Status: API review completed, 1.30
SIG Apps
Archived in project
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.

PodSpec.hostAliases has a potentially misleading comment about hostNetwork