New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP 3836 - promote to beta #122914
KEP 3836 - promote to beta #122914
Conversation
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
/approve
LGTM label has been added. Git tree hash: 732769402f1dc9be89b510aa81ad75c7c14b4585
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexanderConstantinescu, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Would this need a changelog entry? |
Added a simple one indicating the promotion to Beta. Let me know if this is enough? |
Changelog suggestion -Promote KubeProxyDrainingTerminatingNodes to Beta
+Promoted the feature gate `KubeProxyDrainingTerminatingNodes` to beta Please also submit a docs update PR - see https://kubernetes.io/docs/contribute/new-content/new-features/#ready-for-review-feature-gates |
What type of PR is this?
/kind feature
What this PR does / why we need it:
kubernetes/enhancements#3836 was promoted to beta in 1.29, see kubernetes/enhancements#4258. I however forgot to update the feature gate in 1.29....I only realised this now when going over the KEP work for 1.30 :/
I am therefore updating the feature gate to beta here, following what was already agreed.
/assign @thockin
/sig network
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: