e2e_node: fix DevicePlugin feature flags #123160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
bart0sh
force-pushed
the
PR133-e2e-node-device-plugin-fix-features
branch
from
423139f
to
132142e
Compare
k8s-ci-robot
added
area/test
sig/node
|
@swatisehgal It could be that I misunderstood which DevicePlugin e2e tests should be running by which jobs. Can you point me out to the jobs(s) running generic device plugins and device manager tests? It looks like |
bart0sh
force-pushed
the
PR133-e2e-node-device-plugin-fix-features
branch
from
132142e
to
ca3b79d
Compare
k8s-ci-robot
added
size/S
|
@SergeyKanzhelev To your question about real GPU jobs. There is at least one: https://testgrid.k8s.io/sig-release-master-blocking#gce-device-plugin-gpu-master and it seems to run one GPU test: https://github.com/kubernetes/kubernetes/blob/master/test/e2e/scheduling/nvidia-gpus.go#L327. Additionally it runs windows test case for DevicePlugin, but this should be fixed by this PR. |
|
/test |
|
@kannon92: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
removed
the
sig/windows
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 0384d717aed763413a2363ffce72eeb7ecfc0bec
|
SergeyKanzhelev
moved this from PRs - Needs Reviewer
to PRs - Needs Approver
in SIG Node CI/Test Board
k8s-ci-robot
added
the
needs-rebase
bart0sh
force-pushed
the
PR133-e2e-node-device-plugin-fix-features
branch
from
59d9882
to
cbecdcb
Compare
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
removed
the
needs-rebase
|
@kannon92 @SergeyKanzhelev @klueska rebased, PTAL |
Feature:DevicePluginProbe and NodeFeature:DevicePluginProbe are not used by any of the test-infra jobs. This commit renames NodeFeature:DevicePluginProbe to NodeFeature:DevicePlugin and removes Feature:DevicePlugin and Feature:DeviceManager to avoid having both Feature and NodeFeature tags for the same feature. NOTE: Test-infra SIG-Node jobs should focus on the NodeFeature:DevicePlugin to run generic Device Plugins tests.
bart0sh
force-pushed
the
PR133-e2e-node-device-plugin-fix-features
branch
from
cbecdcb
to
ba7a74a
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: d3001cf17eab24cd9a25f39841f74cc0cac8f3de
|
|
@SergeyKanzhelev @dims @mrunalp can you review and approve? |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bart0sh, dims, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@bart0sh: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Feature:DevicePluginProbe and NodeFeature:DevicePluginProbe are not used by any of the test-infra jobs.
This commit renames NodeFeature:DevicePluginProbe to NodeFeature:DevicePlugin and removes Feature:DevicePlugin and Feature:DeviceManager to avoid having both Feature and NodeFeature tags for the same feature.
NOTE: Test-infra SIG-Node jobs should focus on the NodeFeature:DevicePlugin to run generic Device Plugins tests.
Does this PR introduce a user-facing change?