New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add allowed/denied metrics for authorizers #123333
Merged
Merged
+301
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
label
Feb 16, 2024
k8s-ci-robot
added
the
kind/feature
Categorizes issue or PR as related to a new feature.
label
Feb 16, 2024
k8s-ci-robot
added
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
sig/auth
Categorizes an issue or PR as relevant to SIG Auth.
area/apiserver
labels
Feb 16, 2024
k8s-ci-robot
added
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
area/test
sig/api-machinery
Categorizes an issue or PR as relevant to SIG API Machinery.
needs-triage
Indicates an issue or PR lacks a `triage/foo` label and requires one.
sig/testing
Categorizes an issue or PR as relevant to SIG Testing.
needs-priority
Indicates a PR lacks a `priority/foo` label and requires one.
labels
Feb 16, 2024
liggitt
force-pushed
the
authz-metrics
branch
from
February 16, 2024 07:37
f6c69a6
to
4ab02a4
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
liggitt
force-pushed
the
authz-metrics
branch
from
February 16, 2024 13:21
4ab02a4
to
d5d3edd
Compare
/retest |
/lgtm |
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Feb 18, 2024
LGTM label has been added. Git tree hash: eedb23ff2ffb4b1eb208dbf4f65c5504472eae5c
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
Indicates an issue or PR is ready to be actively worked on.
and removed
needs-triage
Indicates an issue or PR lacks a `triage/foo` label and requires one.
labels
Feb 20, 2024
This was referenced Mar 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
area/apiserver
area/test
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
kind/feature
Categorizes issue or PR as related to a new feature.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
needs-priority
Indicates a PR lacks a `priority/foo` label and requires one.
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
sig/api-machinery
Categorizes an issue or PR as relevant to SIG API Machinery.
sig/auth
Categorizes an issue or PR as relevant to SIG Auth.
sig/testing
Categorizes an issue or PR as relevant to SIG Testing.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
triage/accepted
Indicates an issue or PR is ready to be actively worked on.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Records metrics for terminal decisions by all configured authorizers.
Which issue(s) this PR fixes:
Fixes #123324
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/sig auth
/assign @ritazh @palnabarun @enj