Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graduate PodSchedulingReadiness to stable #123575

Merged

Conversation

Huang-Wei
Copy link
Member

@Huang-Wei Huang-Wei commented Feb 29, 2024

What type of PR is this?

/kind feature
/sig scheduling

What this PR does / why we need it:

Graduate PodSchedulingReadiness to stable

Which issue(s) this PR fixes:

Part of kubernetes/enhancements#3521

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Graduated pod scheduling gates to general availability.
The `PodSchedulingReadiness` feature gate no longer has any effect, and the
`.spec.schedulingGates` field is always available within the Pod and PodTemplate APIs.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-scheduling/3521-pod-scheduling-readiness

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/code-generation area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 29, 2024
@Huang-Wei
Copy link
Member Author

API changes only involve document updates.

@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@Huang-Wei Huang-Wei force-pushed the pod-scheduling-readiness-stable branch from afd8d2c to ffa183a Compare February 29, 2024 07:19
@sftim
Copy link
Contributor

sftim commented Feb 29, 2024

Changelog suggestion

-Graduate PodSchedulingReadiness to stable
+Graduated pod scheduling gates to general availability.
+The `PodSchedulingReadiness` feature gate no longer has any effect, and the
+`.spec.schedulingGates` field is always available within the Pod and PodTemplate APIs.

@bart0sh bart0sh added this to Triage in SIG Node PR Triage Feb 29, 2024
@Huang-Wei
Copy link
Member Author

cc @ahg-g

@ahg-g
Copy link
Member

ahg-g commented Feb 29, 2024

/lgtm

Thanks Wei!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 29, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fbeb3ff333c255b1fd6c9102c42e12d174b6237e

@Huang-Wei
Copy link
Member Author

@liggitt would you minding review the API parts (comments update only)?

@liggitt
Copy link
Member

liggitt commented Mar 2, 2024

API comments lgtm, one question on the order change in the default multipoint scheduler plugins

@liggitt
Copy link
Member

liggitt commented Mar 4, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Huang-Wei, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2024
@k8s-ci-robot k8s-ci-robot merged commit e4a14fe into kubernetes:master Mar 4, 2024
16 checks passed
SIG Node PR Triage automation moved this from Triage to Done Mar 4, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Mar 4, 2024
@Huang-Wei Huang-Wei deleted the pod-scheduling-readiness-stable branch March 5, 2024 01:22
@cici37 cici37 added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Apr 11, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

7 participants